Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document a workflow for investigating performance regressions. #269

Merged
merged 5 commits into from
Oct 4, 2022

Conversation

ian-r-rose
Copy link
Contributor

cc @hayesgb, who expressed some interest in this

@ian-r-rose ian-r-rose added documentation Improvements or additions to documentation dx Developer experience labels Aug 19, 2022
@ian-r-rose ian-r-rose self-assigned this Aug 23, 2022
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ncclementi ncclementi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR makes sense to merge it once we are using package sync. Otherwise, there are a couple of things you need to tweak to be able to use it. Or we could temporarily document those tweaks, and then once the package sync PR is merged, remove them.

Thoughts?

@ian-r-rose
Copy link
Contributor Author

I'll clarify some of the things you ran into. But I agree, this doesn't make much sense to merge until package_sync is in

README.md Outdated Show resolved Hide resolved
Co-authored-by: Naty Clementi <natyclementi@gmail.com>
README.md Outdated Show resolved Hide resolved
Co-authored-by: Naty Clementi <natyclementi@gmail.com>
@ncclementi
Copy link
Contributor

@ian-r-rose should we fix conflicts and get this one in since package sync is already in?

@ian-r-rose
Copy link
Contributor Author

Good point, I forgot about this one! Updating now...

@ian-r-rose
Copy link
Contributor Author

Okay, should be ready

@ncclementi
Copy link
Contributor

Thank you Ian! I'll wait for CI and then I'll merge it.

@ncclementi
Copy link
Contributor

Failures and regressions are known flaky and noisy repspectively. SInce this is purely docs I'll go ahead and merge it in.
Thank you @ian-r-rose for your work here.

@ncclementi ncclementi merged commit a5fa18b into main Oct 4, 2022
@ncclementi ncclementi deleted the bisect-workflow branch October 4, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation dx Developer experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants