Fix passing credentials to gcsfs

[j-bennet]

According to the docs here:

https://gcsfs.readthedocs.io/en/latest/index.html#credentials

gcsfs does not accept just a token, it needs a Credentials instance or a dict. For dask dict works better, because it can be pickled.

We also pass the same credentials to to_parquet.

[j-bennet]

@bnaul What do you think is going on here?

https://github.com/coiled/dask-bigquery/actions/runs/4997384122/jobs/8951694334?pr=66#step:6:105

E           	debug_error_string = "UNKNOWN:Error received from peer ipv4:172.217.10.106:443 ***grpc_message:"request failed: Cannot query over table \'***.bddf1d76129e47f8988633536743ba96.partitioned_table_test\' without a filter over column(s) \'timestamp\' that can be used for partition elimination", grpc_status:3, created_time:"2023-05-16T22:58:45.81916+00:00"***"

it's happening on a line that is supposed to raise:

        with pytest.raises(InvalidArgument):
>           read_gbq(
                project_id=project_id,
                dataset_id=dataset_id,
                table_id=table_id,
            ).head()

but apparently it's raising something different.

[bnaul]

probably we should just check the text rather than the exception type, I just used whatever was being raised for me at the time but it's not important for us what they raise

…

On Tue, May 16, 2023, 8:07 PM Irina Truong ***@***.***> wrote: @j-bennet <https://github.com/j-bennet> requested your review on: #66 <#66> Fix passing credentials to gcsfs. — Reply to this email directly, view it on GitHub <#66 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAG4TZ3JMBZTWMRID6JTFLDXGQJEJANCNFSM6AAAAAAYC5OE7Y> . You are receiving this because your review was requested.Message ID: ***@***.***>

[martindurant]

I hadn't realised that the gcsfs discussion was the same as the one here. As in the liked issue, it would not be too difficult to have gcsfs accept a raw token, either working around the current system or making a small PR to gcsfs. It would, of course, not be able to refresh and eventually return permission errors if the token has expired.

[j-bennet]

@martindurant I'm going to try making a change in gcsfs. Might need your help with that one.

[jrbourbeau]

Thanks @j-bennet