Skip to content
This repository has been archived by the owner on Oct 18, 2023. It is now read-only.

fix(coil-extension): reduce code injections to 1 #1254

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

sublimator
Copy link
Member

@sublimator sublimator commented Nov 3, 2020

Related to #1248

We may end up moving to emitting events on window directly, but even in that case, we'll need to provide support for old sites, along with deprecation warnings, so there is some value in reducing the amount of injections.

@wmurphyrd
Copy link

If you were to wrap that script injection in a try/catch, I think it would it be now possible to have full functioning under CSP without the script-src directives by simply running that short document.monetization polyfill script from the main paige

@sublimator
Copy link
Member Author

@wmurphyrd Thanks for your input!

Yeah, I was pondering the same thing actually.
It's potentially more maintainable that way too.

@sublimator sublimator force-pushed the nd-reduce-number-script-injections-2020-11-03 branch from e57070c to b27a581 Compare November 4, 2020 02:56
@sublimator sublimator merged commit a367f8d into main Nov 4, 2020
@sublimator sublimator deleted the nd-reduce-number-script-injections-2020-11-03 branch November 17, 2020 07:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants