Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji support for webhooks #8

Merged
merged 3 commits into from
Aug 9, 2020
Merged

Emoji support for webhooks #8

merged 3 commits into from
Aug 9, 2020

Conversation

alar77
Copy link
Contributor

@alar77 alar77 commented May 3, 2018

A one line change to retrieve emoji preference set via hook.channeò_username_emoji

alar77 added 2 commits May 3, 2018 12:29
hook.postMessage was not honoring a previous set emoji (via hook.channel_username_emoji
Added emoj support to webhook
@coin-au-carre
Copy link
Owner

Hello thanks for the PR sorry for the late response.
When do you use str_emoji? It seems unused.

My bad, when I prepared the pr I missed to modify the JSON assignment line
@alar77
Copy link
Contributor Author

alar77 commented Apr 30, 2019

What a moron I am . I made two changes in the code but only ported one.
Hopefully all makes sense now

@coin-au-carre coin-au-carre merged commit 9e9c114 into coin-au-carre:master Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants