Incorrect counting of processed nodes; crash

[svigerske]

Issue created by migration from Trac.

Original creator: fmargot

Original creation time: 2006-12-26 14:09:49

Assignee: somebody

Version:

CC: fmargot@andrew.cmu.edu

This is for the tar ball BCP-1.0.0, but the code in the stable version looks similar.

It seems that the counting of processed nodes when BCP hits the time limit is incorrect. I get:

TM: Time has ran out.

TM: Best lower bound in this phase: 17.000000

WARNING! processed != p->search_tree.processed()

WARNING! Please file a bug report.

When printing these values, I get:

processed: 2195 p->search_tree.processed(): 1329

This happens using stein27.mps with an upper bound of 18.1, a time limit of 10 seconds and BCP in Branch-and-Bound (using best bound) mode.

This comes from BCP_tm_user::display_final_information(). Moreover, when using

BCP_RemoveExploredBranches 1

it happens that in the loop of BCP_tm_user::display_final_information()
starting with

for (BCP_vec<BCP_tm_node*>::iterator node = p->search_tree.begin();
node != p->search_tree.end();
++node) {

(around line 291 in BCP_tm_user.cpp), *node is sometimes NULL, creating a crash. I fixed this by adding at the beginning of the loop:

if(*node == NULL) {
continue;
}

I am not sure if this is the best fix.

[svigerske]

Comment by ladanyi created at 2006-12-30 18:39:57

Changing assignee from somebody to ladanyi.

[svigerske]

Comment by ladanyi created at 2006-12-30 18:39:57

Changing status from new to assigned.