Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove embedded experience #272

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Remove embedded experience #272

wants to merge 1 commit into from

Conversation

zack-winchell-cb
Copy link
Contributor

@zack-winchell-cb zack-winchell-cb commented May 7, 2024 •
edited
Loading

Description & motivation

  • Remove embedded experience
  • Update popup to new default experience
  • Update CoinbasePixel.endExperience to work outside of Chromium
    • Chromium window/tab closing can be added as a followup.

Testing & documentation

Tested locally & updated README.

@zack-winchell-cb
Remove embedded experience
e419197 
Close popup on endExperience
@zack-winchell-cb zack-winchell-cb marked this pull request as draft May 8, 2024 16:03
@MITCHELLNEAL1
Copy link

Description & motivation

* Remove `embedded` experience

* Update `popup` to new default experience

* Update `CoinbasePixel.endExperience` to work outside of Chromium
  
  * Chromium window/tab closing can be added as a followup.

Testing & documentation

Tested locally & updated README.

@MITCHELLNEAL1
Copy link

ok

1 similar comment
@MITCHELLNEAL1
Copy link

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumxu96 sumxu96 sumxu96 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zack-winchell-cb @MITCHELLNEAL1 @sumxu96