Skip to content
This repository has been archived by the owner on Mar 3, 2020. It is now read-only.

Commit

Permalink
Default version set to today's date
Browse files Browse the repository at this point in the history
  • Loading branch information
@maksim-s
maksim-s committed Feb 17, 2016
1 parent 86f241a commit c2169fb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/ClientBase.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ ClientBase.prototype._generateReqOptions = function(url, path, body, method, hea
'CB-ACCESS-SIGN': sig.digest,
'CB-ACCESS-TIMESTAMP': sig.timestamp,
'CB-ACCESS-KEY': this.apiKey,
'CB-VERSION': this.version || ''
'CB-VERSION': this.version || (new Date()).toISOString().split('T')[0]

This comment has been minimized.

Sign in to view

Copy link
@franciscolourenco

franciscolourenco Feb 18, 2016

Shouldn't default version be hardcoded and changed every time there is a version bump for this library? Otherwise there is the possibility that the library breaks over time if it doesn't get upgraded by the user.

This comment has been minimized.

Sign in to view

Copy link
@maksim-s

maksim-s Feb 18, 2016

Author Contributor

you are right. Fix coming in the next version. Thank you!
})
}

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "coinbase",
"version": "2.0.2",
"version": "2.0.3",
"author": "Coinbase",
"bugs": "https://github.com/coinbase/coinbase-node/issues",
"contributors": [
Expand Down

0 comments on commit c2169fb

Please sign in to comment.