This repository has been archived by the owner on Jan 20, 2020. It is now read-only.
Refactor auth object to { key, secret, passphrase } #151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This more consistent usage allows an
AuthenticatedClient
instance to be usedin place of an
auth
object thereby simplifying codebase and general usage patterns.AuthenticatedClient
used to have ab64secret
property, but all auth object credentials expected asecret
property. By making the two consistent, we gain better consistency, and the codebase can be simplified a bit.Other considerations
This will likely need to be rebased after #150 is merged.