This repository has been archived by the owner on Jan 20, 2020. It is now read-only.
Fix request error handling #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that non-2xx response codes return an error
|
/cc @fb55 This one is kind of important, IMO. |
This was referenced Jan 8, 2018
fb55
reviewed
Jan 18, 2018
lib/clients/public.js
Outdated
| } | ||
| if (data === null) { | ||
| } else if (response.statusCode > 299) { | ||
| err = new Error(`HTTP ${response.statusCode} Error`); |
There was a problem hiding this comment.
Use the message from the response here?
There was a problem hiding this comment.
Do you mean the statusMessage from the response, or the message from the body, or both? I'm inclined to try both.
There was a problem hiding this comment.
message from the body. statusMessage wouldn't be too bad either 🤷♂️
|
@fb55 I added the body's error message to the Error object's message. I skipped the |
|
Amazing, thanks a lot! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Related Issues