Heartbeat

[amejiarosario]

Adds the heartbeat option to Websocket

[amejiarosario]

Could any of you please review these changes?
@awitherow @gcperrin @givanse @mihar Thanks!

[awitherow]

Looks good to me!

I just would like to see some better error handling and a more verbose readme of how the websocket function works for people who might not be confident enough to dig into the source code.

[awitherow]

Due to the breaking changes in the way the WebsocketClient takes parameters, do you think it would be good to add the following more parameter error handling?

For example, maybe checking to ensure that options is in fact an object, and not a string (perhaps websocketURI).

[awitherow]

This is not the only case either, just a thought of one potential.

The idea is to look at this and ensure it is as backwards compatible friendly as possible, without making it mess.

[awitherow]

Here it would be good to expand upon the optional parameters (websocket URI, authentication) just so that people know more without having to dig into the code themselves to figure out how it works, or why their old implementation is breaking if they've upgraded.

[amejiarosario]

ok, I'll update

[fb55]

@amejiarosario This needs a rebase, great patch otherwise.

[amejiarosario]

@awitherow made it backward compatible.
@fb55 rebased!

[fb55]

@amejiarosario Thanks a lot! We should update this to use the heartbeat channel, but I didn't want to block this any further.