-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor method names and where asset, balance, and import logic lives #41
Commits on May 10, 2024
-
Migrate get_balance(s) to
balance(s)
This migrates the get_balance* calls to balance* to be more inline with standard ruby method naming, i.e. the method name should reflect what is being returned v.s. what the method is doing.
Configuration menu - View commit details
-
Copy full SHA for eb36317 - Browse repository at this point
Copy the full SHA eb36317View commit details -
Configuration menu - View commit details
-
Copy full SHA for f89912e - Browse repository at this point
Copy the full SHA f89912eView commit details -
This removes the reference to the unused FaucetLimitReached error and updates docs to refer to the correct FaucetLimitReachedError
Configuration menu - View commit details
-
Copy full SHA for 7cc33ef - Browse repository at this point
Copy the full SHA 7cc33efView commit details -
Add Wallet.import method for importing a wallet
This enables you to import a wallet with the export data directly.
Configuration menu - View commit details
-
Copy full SHA for 841a4d0 - Browse repository at this point
Copy the full SHA 841a4d0View commit details -
Migrate balance map to class method
This migrates the balance map parsing off of the top-level Coinbase class and onto the Coinbase::BalanceMap class as a class method. This also exposes a `Coinbase::Balance` object for simple parsing of Coinbase::Client::Balances.
Configuration menu - View commit details
-
Copy full SHA for 4185ff0 - Browse repository at this point
Copy the full SHA 4185ff0View commit details -
Migrate model.model_id to model.id
This makes it so that our fetches of the resource ID doesn't stutter with the class name. ```ruby wallet = Wallet.import(...) puts wallet.id ```
Configuration menu - View commit details
-
Copy full SHA for 0f94795 - Browse repository at this point
Copy the full SHA 0f94795View commit details -
Consolidate asset and balance handling
This consolidates the transforms around assets and balances to their respective classes, and moves them out of wallet and address. This also adds testing and fixes the handling for fetching balances of `weth` using `get_address_balance` and `get_wallet_balance` which was not handled properly. The `list_address_balances` and `list_wallet_balances` handling properly handled `weth`.
Configuration menu - View commit details
-
Copy full SHA for ff69c26 - Browse repository at this point
Copy the full SHA ff69c26View commit details -
Return transfers on address object
This makes it so that we return address.transfers instead of address.list_transfer_ids.
Configuration menu - View commit details
-
Copy full SHA for 8fed7b4 - Browse repository at this point
Copy the full SHA 8fed7b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7634f72 - Browse repository at this point
Copy the full SHA 7634f72View commit details
Commits on May 13, 2024
-
Update all ID fields and add specs
This updates all model's fields and adds specs that test the inspect function to ensure we're evaluating those functions in test.
Configuration menu - View commit details
-
Copy full SHA for 46632bd - Browse repository at this point
Copy the full SHA 46632bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e198ce - Browse repository at this point
Copy the full SHA 5e198ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for b5eaffc - Browse repository at this point
Copy the full SHA b5eaffcView commit details