Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PSDK-71] Implement user.wallets #45

Merged
merged 18 commits into from
May 15, 2024
Merged

[PSDK-71] Implement user.wallets #45

merged 18 commits into from
May 15, 2024

Conversation

yuga-cb
Copy link
Contributor

@yuga-cb yuga-cb commented May 14, 2024

What changed? Why?

Implement user.wallets by introducing the concept of hydration of wallets/addresses. Get rid of the N GetAddress calls.

Qualified Impact

@yuga-cb yuga-cb requested a review from alex-stone May 14, 2024 23:21
lib/coinbase/wallet.rb Outdated Show resolved Hide resolved
lib/coinbase/wallet.rb Outdated Show resolved Hide resolved
@yuga-cb yuga-cb requested a review from alex-stone May 15, 2024 16:45
@yuga-cb yuga-cb requested a review from jazz-cb May 15, 2024 17:56
lib/coinbase/wallet.rb Outdated Show resolved Hide resolved
@yuga-cb yuga-cb changed the base branch from master to v0.0.5 May 15, 2024 18:28
@yuga-cb yuga-cb merged commit 9f38a52 into v0.0.5 May 15, 2024
6 of 7 checks passed
@yuga-cb yuga-cb deleted the yuga/pagination branch May 15, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants