Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No network checking or alerts (danger!) #39

Closed
pi0neerpat opened this issue Jul 7, 2020 · 1 comment
Closed

No network checking or alerts (danger!) #39

pi0neerpat opened this issue Jul 7, 2020 · 1 comment

Comments

@pi0neerpat
Copy link

pi0neerpat commented Jul 7, 2020

Issue

Currently there is no network check when making a transaction request. This could mean losing funds (!!) for a developer who is testing using another network.

Steps to reproduce

const ETH_JSONRPC_URL = `https://mainnet.infura.io/v3/${infuraKey}`;
const CHAIN_ID = 1;
const ethereum = walletLink.makeWeb3Provider(ETH_JSONRPC_URL, CHAIN_ID);

Change your test wallet network to something besides mainnet. Then push any transaction to the wallet.

Possible solution

  • There should be some indicator that the network for the transaction is mainnet. This is only really relevant while on a testnet, so normal users would never see it,
@pi0neerpat pi0neerpat changed the title No network checking or alerts No network checking or alerts (danger!) Jul 7, 2020
@brendanww
Copy link
Contributor

We display the network name in transaction modals on all clients now.

bangtoven added a commit that referenced this issue Feb 29, 2024
* limit Message types

* code cleanup

* keystorage

* revert tsconfig change

* revert

* move

* adding tests

* Revert "Clean up WalletLink for WalletLinkConnector and SCWSession (#36)"

This reverts commit 9631822b7f8fff6c9888d5804daa33a06d487f79.

* import/export
bangtoven added a commit that referenced this issue Feb 29, 2024
* limit Message types

* code cleanup

* keystorage

* revert tsconfig change

* revert

* move

* adding tests

* Revert "Clean up WalletLink for WalletLinkConnector and SCWSession (#36)"

This reverts commit 9631822b7f8fff6c9888d5804daa33a06d487f79.

* import/export
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants