New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Support for mobile deep linking from dapp app to wallet app #945

Closed

hamberluo opened this issue Jul 22, 2023 · 1 comment

Labels

type: enhancement

hamberluo commented Jul 22, 2023

Is your feature request related to a problem? Please describe.

No response

Describe the solution you'd like

coinbase://wc?uri=

Describe alternatives you've considered

No response

Additional context

No response

hamberluo added the type: enhancement label

Contributor

bangtoven commented Aug 21, 2023

hi. sorry for late response.
please try the new enableMobileWalletLink flag on our latest beta version, v3.8.x

bangtoven closed this as completed

Ashoat added a commit to CommE2E/comm that referenced this issue


          [lib] Add Coinbase Wallet support

1f4bc6d

Summary: This addresses [ENG-2985](https://linear.app/comm/issue/ENG-2985/add-support-for-coinbase-wallet).

The patchfile change is necessary to get Rainbowkit to pass [this config](https://github.com/wevm/wagmi/blame/2d5041668d6b5e28bec21de349275ca584597082/docs/shared/connectors/coinbaseWallet.md#L111) to Wagmi.

I described it when searching the GitHub issues for `coinbase-wallet-sdk`: [here](coinbase/coinbase-wallet-sdk#945 (comment)) and [here](coinbase/coinbase-wallet-sdk#854 (comment)). I also found a Farcaster discussion about it [here](https://searchcaster.xyz/search?merkleRoot=0xfa7da182c0998d9e68d99f5535416a0816872976).

Depends on D11491

Test Plan: Testing on `web` running locally, and on `native` device via `landing`. Second part was tough... had to test patches on production because I couldn't get my local `landing` to render on my physical device

Reviewers: atul, ginsu

Subscribers:

Ashoat added a commit to CommE2E/comm that referenced this issue


          [lib] Add Coinbase Wallet support

241306e

Summary:
This addresses [ENG-2985](https://linear.app/comm/issue/ENG-2985/add-support-for-coinbase-wallet).

The patchfile change is necessary to get Rainbowkit to pass [this config](https://github.com/wevm/wagmi/blame/2d5041668d6b5e28bec21de349275ca584597082/docs/shared/connectors/coinbaseWallet.md#L111) to Wagmi.

I described it when searching the GitHub issues for `coinbase-wallet-sdk`: [here](coinbase/coinbase-wallet-sdk#945 (comment)) and [here](coinbase/coinbase-wallet-sdk#854 (comment)). I also found a Farcaster discussion about it [here](https://searchcaster.xyz/search?merkleRoot=0xfa7da182c0998d9e68d99f5535416a0816872976).

Depends on D11491

Test Plan: Testing on `web` running locally, and on `native` device via `landing`. Second part was tough... had to test patches on production because I couldn't get my local `landing` to render on my physical device

Reviewers: atul, ginsu

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D11492

Ashoat added a commit to CommE2E/comm that referenced this issue


          [lib] Add Coinbase Wallet support

8e7ca53

Summary:
This addresses [ENG-2985](https://linear.app/comm/issue/ENG-2985/add-support-for-coinbase-wallet).

The patchfile change is necessary to get Rainbowkit to pass [this config](https://github.com/wevm/wagmi/blame/2d5041668d6b5e28bec21de349275ca584597082/docs/shared/connectors/coinbaseWallet.md#L111) to Wagmi.

I described it when searching the GitHub issues for `coinbase-wallet-sdk`: [here](coinbase/coinbase-wallet-sdk#945 (comment)) and [here](coinbase/coinbase-wallet-sdk#854 (comment)). I also found a Farcaster discussion about it [here](https://searchcaster.xyz/search?merkleRoot=0xfa7da182c0998d9e68d99f5535416a0816872976).

Depends on D11491

Test Plan: Testing on `web` running locally, and on `native` device via `landing`. Second part was tough... had to test patches on production because I couldn't get my local `landing` to render on my physical device

Reviewers: atul, ginsu

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D11492

Ashoat added a commit to CommE2E/comm that referenced this issue


          [lib] Add Coinbase Wallet support

8a59463

Summary:
This addresses [ENG-2985](https://linear.app/comm/issue/ENG-2985/add-support-for-coinbase-wallet).

The patchfile change is necessary to get Rainbowkit to pass [this config](https://github.com/wevm/wagmi/blame/2d5041668d6b5e28bec21de349275ca584597082/docs/shared/connectors/coinbaseWallet.md#L111) to Wagmi.

I described it when searching the GitHub issues for `coinbase-wallet-sdk`: [here](coinbase/coinbase-wallet-sdk#945 (comment)) and [here](coinbase/coinbase-wallet-sdk#854 (comment)). I also found a Farcaster discussion about it [here](https://searchcaster.xyz/search?merkleRoot=0xfa7da182c0998d9e68d99f5535416a0816872976).

Depends on D11491

Test Plan: Testing on `web` running locally, and on `native` device via `landing`. Second part was tough... had to test patches on production because I couldn't get my local `landing` to render on my physical device

Reviewers: atul, ginsu

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D11492

Ashoat added a commit to CommE2E/comm that referenced this issue


          [lib] Add Coinbase Wallet support

b5490fa

Summary:
This addresses [ENG-2985](https://linear.app/comm/issue/ENG-2985/add-support-for-coinbase-wallet).

The patchfile change is necessary to get Rainbowkit to pass [this config](https://github.com/wevm/wagmi/blame/2d5041668d6b5e28bec21de349275ca584597082/docs/shared/connectors/coinbaseWallet.md#L111) to Wagmi.

I described it when searching the GitHub issues for `coinbase-wallet-sdk`: [here](coinbase/coinbase-wallet-sdk#945 (comment)) and [here](coinbase/coinbase-wallet-sdk#854 (comment)). I also found a Farcaster discussion about it [here](https://searchcaster.xyz/search?merkleRoot=0xfa7da182c0998d9e68d99f5535416a0816872976).

Depends on D11491

Test Plan: Testing on `web` running locally, and on `native` device via `landing`. Second part was tough... had to test patches on production because I couldn't get my local `landing` to render on my physical device

Reviewers: atul, ginsu

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D11492

Ashoat added a commit to CommE2E/comm that referenced this issue


          [lib] Add Coinbase Wallet support

3b15e56

Summary:
This addresses [ENG-2985](https://linear.app/comm/issue/ENG-2985/add-support-for-coinbase-wallet).

The patchfile change is necessary to get Rainbowkit to pass [this config](https://github.com/wevm/wagmi/blame/2d5041668d6b5e28bec21de349275ca584597082/docs/shared/connectors/coinbaseWallet.md#L111) to Wagmi.

I described it when searching the GitHub issues for `coinbase-wallet-sdk`: [here](coinbase/coinbase-wallet-sdk#945 (comment)) and [here](coinbase/coinbase-wallet-sdk#854 (comment)). I also found a Farcaster discussion about it [here](https://searchcaster.xyz/search?merkleRoot=0xfa7da182c0998d9e68d99f5535416a0816872976).

Depends on D11491

Test Plan: Testing on `web` running locally, and on `native` device via `landing`. Second part was tough... had to test patches on production because I couldn't get my local `landing` to render on my physical device

Reviewers: atul, ginsu

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D11492

Ashoat added a commit to CommE2E/comm that referenced this issue


          [lib] Add Coinbase Wallet support

6e3d6a1

Summary:
This addresses [ENG-2985](https://linear.app/comm/issue/ENG-2985/add-support-for-coinbase-wallet).

The patchfile change is necessary to get Rainbowkit to pass [this config](https://github.com/wevm/wagmi/blame/2d5041668d6b5e28bec21de349275ca584597082/docs/shared/connectors/coinbaseWallet.md#L111) to Wagmi.

I discovered it when searching the GitHub issues for `coinbase-wallet-sdk`: [here](coinbase/coinbase-wallet-sdk#945 (comment)) and [here](coinbase/coinbase-wallet-sdk#854 (comment)). I also found a Farcaster discussion about it [here](https://searchcaster.xyz/search?merkleRoot=0xfa7da182c0998d9e68d99f5535416a0816872976).

Depends on D11491

Test Plan: Testing on `web` running locally, and on `native` device via `landing`. Second part was tough... had to test patches on production because I couldn't get my local `landing` to render on my physical device

Reviewers: atul, ginsu

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D11492

Ashoat added a commit to CommE2E/comm that referenced this issue


          [lib] Add Coinbase Wallet support

32eb53a

Summary:
This addresses [ENG-2985](https://linear.app/comm/issue/ENG-2985/add-support-for-coinbase-wallet).

The patchfile change is necessary to get Rainbowkit to pass [this config](https://github.com/wevm/wagmi/blame/2d5041668d6b5e28bec21de349275ca584597082/docs/shared/connectors/coinbaseWallet.md#L111) to Wagmi.

I discovered it when searching the GitHub issues for `coinbase-wallet-sdk`: [here](coinbase/coinbase-wallet-sdk#945 (comment)) and [here](coinbase/coinbase-wallet-sdk#854 (comment)). I also found a Farcaster discussion about it [here](https://searchcaster.xyz/search?merkleRoot=0xfa7da182c0998d9e68d99f5535416a0816872976).

Depends on D11491

Test Plan: Testing on `web` running locally, and on `native` device via `landing`. Second part was tough... had to test patches on production because I couldn't get my local `landing` to render on my physical device

Reviewers: atul, ginsu

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D11492

Ashoat added a commit to CommE2E/comm that referenced this issue


          [lib] Add Coinbase Wallet support

1005cb0

Summary:
This addresses [ENG-2985](https://linear.app/comm/issue/ENG-2985/add-support-for-coinbase-wallet).

The patchfile change is necessary to get Rainbowkit to pass [this config](https://github.com/wevm/wagmi/blame/2d5041668d6b5e28bec21de349275ca584597082/docs/shared/connectors/coinbaseWallet.md#L111) to Wagmi.

I discovered it when searching the GitHub issues for `coinbase-wallet-sdk`: [here](coinbase/coinbase-wallet-sdk#945 (comment)) and [here](coinbase/coinbase-wallet-sdk#854 (comment)). I also found a Farcaster discussion about it [here](https://searchcaster.xyz/search?merkleRoot=0xfa7da182c0998d9e68d99f5535416a0816872976).

Depends on D11491

Test Plan: Testing on `web` running locally, and on `native` device via `landing`. Second part was tough... had to test patches on production because I couldn't get my local `landing` to render on my physical device

Reviewers: atul, ginsu

Reviewed By: ginsu

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D11492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment