#trivial Clean up cross domain communicator #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangtoven
commented
May 1, 2024
packages/wallet-sdk/src/core/communicator/CrossDomainCommunicator.ts
Outdated
Show resolved
Hide resolved
This reverts commit 5669680. # Conflicts: # packages/wallet-sdk/src/core/communicator/PopUpCommunicator.ts
bangtoven
force-pushed
the
jungho/cleanup-xdomain-comm
branch
from
7a10359
to
d8cd911
Compare
bangtoven
force-pushed
the
jungho/cleanup-xdomain-comm
branch
from
3bad89e
to
f84240a
Compare
bangtoven
changed the title
auto-merge was automatically disabled
May 1, 2024 15:59
Pull request was converted to draft
commit 8067edd Author: Jungho Bang <jungho.bang@coinbase.com> Date: Wed May 1 01:04:15 2024 -0700 min diff commit 0fd1b72 Author: Jungho Bang <jungho.bang@coinbase.com> Date: Wed May 1 01:00:27 2024 -0700 fix test commit 487870a Author: Jungho Bang <jungho.bang@coinbase.com> Date: Wed May 1 00:52:53 2024 -0700 cleaner commit b427e5a Author: Jungho Bang <jungho.bang@coinbase.com> Date: Wed May 1 00:46:41 2024 -0700 hmmm. back to abstract commit ba9c7b0 Author: Jungho Bang <jungho.bang@coinbase.com> Date: Wed May 1 00:27:13 2024 -0700 SignHandler is PopUpCommunicator commit 86e585a Merge: 1e1fb4c 07a99c5 Author: Jungho Bang <jungho.bang@coinbase.com> Date: Tue Apr 30 23:43:18 2024 -0700 Merge branch 'jungho/cleanup-xdomain-comm' into jungho/refactor-puc # Conflicts: # packages/wallet-sdk/src/core/communicator/PopUpCommunicator.ts commit 1e1fb4c Author: Jungho Bang <jungho.bang@coinbase.com> Date: Tue Apr 30 23:40:05 2024 -0700 cleaner # Conflicts: # packages/wallet-sdk/src/core/communicator/PopUpCommunicator.ts commit ac2e71d Merge: d6c95a6 16f01bb Author: Jungho Bang <jungho.bang@coinbase.com> Date: Tue Apr 30 23:30:23 2024 -0700 Merge branch 'jungho/cleanup-xdomain-comm' into jungho/refactor-puc commit d6c95a6 Author: Jungho Bang <jungho.bang@coinbase.com> Date: Tue Apr 30 23:28:11 2024 -0700 no temp vars commit ffaac3c Author: Jungho Bang <jungho.bang@coinbase.com> Date: Tue Apr 30 23:23:11 2024 -0700 min diff commit bfb1cf7 Merge: 934757c f84240a Author: Jungho Bang <jungho.bang@coinbase.com> Date: Tue Apr 30 23:19:54 2024 -0700 Merge branch 'jungho/cleanup-xdomain-comm' into jungho/refactor-puc commit 934757c Author: Jungho Bang <jungho.bang@coinbase.com> Date: Tue Apr 30 23:01:07 2024 -0700 WIP # Conflicts: # packages/wallet-sdk/src/core/communicator/CrossDomainCommunicator.ts commit 39bacbe Author: Jungho Bang <jungho.bang@coinbase.com> Date: Tue Apr 30 23:07:10 2024 -0700 Revert "revert onConnect" This reverts commit d8cd911.
bangtoven
commented
May 1, 2024
Comment on lines
+8
to
+10
| protected abstract setupPeerWindow(): Promise<void>; | ||
| // returns true if the message is handled | ||
| protected abstract handleIncomingMessage(_: Message): Promise<boolean>; |
There was a problem hiding this comment.
will use this boolean value in the followup pr
|
fyi @fan-zhang-sv i am closing this. |
bangtoven
commented
May 1, 2024
| this.connected = true; | ||
| } | ||
|
|
||
| disconnect(): void { |
There was a problem hiding this comment.
FE doesn't use onDisconnect nor disconnect
fan-zhang-sv
approved these changes
May 1, 2024
|
Review Error for fan-zhang-sv @ 2024-05-01 20:17:55 UTC |
fan-zhang-sv
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How did you test your changes?