Merge all of internal /js #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -316,7 +338,6 @@ export class WalletLinkRelay { | |||
| } | |||
| if (this.ui.inlineAccountsResponse()) { | |||
| const onAccounts = (accounts: [AddressString]) => { | |||
| console.log("Got accounts response from extension " + accounts[0]) | |||
hieronymus777
approved these changes
Apr 21, 2021
* WIP - Show correct dialog UI based on feature flag * Use in page provider if available * Override setAppInfo. Implement setting chain id and custom rpc url. * Fix formatting * Add ability to set provider info to wallet link provider * Add setAppInfo method to provider * Fix lint error * Fix typo * Remove non-working feature flag code * Revert "Remove non-working feature flag code" This reverts commit 7c2328412b209fc1055c11704683ceb836932c6e. * Remove todo comments Co-authored-by: Alex Shoykhet <alex.shoykhet@coinbase.com>
hieronymus777
pushed a commit
that referenced
this pull request
Nov 18, 2021
* Specify build engines * fix compile error * Fix docker build * Remove unnecessary file from docker
bangtoven
pushed a commit
that referenced
this pull request
Feb 29, 2024
* Merge internal into public * Port over changes from WalletLinkRelay needed for new UI * Merge all of /js * Handle in page provider (#54) * WIP - Show correct dialog UI based on feature flag * Use in page provider if available * Override setAppInfo. Implement setting chain id and custom rpc url. * Fix formatting * Add ability to set provider info to wallet link provider * Add setAppInfo method to provider * Fix lint error * Fix typo * Remove non-working feature flag code * Revert "Remove non-working feature flag code" This reverts commit 7c2328412b209fc1055c11704683ceb836932c6e. * Remove todo comments Co-authored-by: Alex Shoykhet <alex.shoykhet@coinbase.com> * Merge chainId fix, initialize relay if eip1102 already authorized * Remove console\.error Co-authored-by: Alex Shoykhet <alex.shoykhet@coinbase.com> Co-authored-by: Vishnu Madhusoodanan <vishnu.madhusoodanan@coinbase.com>
bangtoven
pushed a commit
that referenced
this pull request
Feb 29, 2024
* wip * provider can handle readonly jsonrpc requests * use chain.rpcUrl * fix testapp connected check * attach id and jsonrpc at the time of request * make storage keys more specific - prefix with Provider: * minor * remove jsonrpcrequest/response types * generic typing * add eth_getBalance to testapp * add test readonly requests to check txn count and balance to testapp * word * add startsWith check for chance at forward compatibility * ts/lint * undo unused optional param change * use uuid for jsonrpcrequest id * move requiresSigning util function to utils file * remove useless promise * eip error * dont use JSONRPCMethod type in testapp
bangtoven
pushed a commit
that referenced
this pull request
Feb 29, 2024
* wip * provider can handle readonly jsonrpc requests * use chain.rpcUrl * fix testapp connected check * attach id and jsonrpc at the time of request * make storage keys more specific - prefix with Provider: * minor * remove jsonrpcrequest/response types * generic typing * add eth_getBalance to testapp * add test readonly requests to check txn count and balance to testapp * word * add startsWith check for chance at forward compatibility * ts/lint * undo unused optional param change * use uuid for jsonrpcrequest id * move requiresSigning util function to utils file * remove useless promise * eip error * dont use JSONRPCMethod type in testapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.