MobileRelay #903
Merged
MobileRelay #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangtoven
commented
Jun 23, 2023
Comment on lines
+128
to
+130
| this._relay = isMobileWeb() | ||
| ? new MobileRelay(relayOption) | ||
| : new WalletLinkRelay(relayOption); |
There was a problem hiding this comment.
branching here for dedicated relay logic
| // override | ||
| public requestEthereumAccounts(): CancelablePromise<RequestEthereumAccountsResponse> { | ||
| if (this._useMobileWalletLink) { | ||
| return super.requestEthereumAccounts(); |
There was a problem hiding this comment.
TODO: deeplink navigation
Comment on lines
+22
to
+37
| promise: new Promise(() => { | ||
| let location: Location; | ||
| try { | ||
| if (isInIFrame() && window.top) { | ||
| location = window.top.location; | ||
| } else { | ||
| location = window.location; | ||
| } | ||
| } catch (e) { | ||
| location = window.location; | ||
| } | ||
|
|
||
| location.href = `https://www.coinbase.com/connect-dapp?uri=${encodeURIComponent( | ||
| location.href, | ||
| )}`; | ||
| }), |
There was a problem hiding this comment.
migrated from WalletLinkRelay/requestEthereumAccounts
vishnumad
approved these changes
Jun 23, 2023
cb-jake
reviewed
Jun 23, 2023
| import { RequestEthereumAccountsResponse } from "./Web3Response"; | ||
|
|
||
| export class MobileRelay extends WalletLinkRelay { | ||
| private _useMobileWalletLink: boolean; |
There was a problem hiding this comment.
Instead of typescript privates we can start using javascript private methods
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes/Private_class_fields
#useMobileWalletLink: boolean;There was a problem hiding this comment.
thanks for flagging that.
will address that during overall refactor.
cb-jake
approved these changes
Jun 23, 2023
bangtoven
added a commit
that referenced
this pull request
Feb 29, 2024
* rename to clarify how the relay connects * introduce MobileRelay * comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
separate relay for mobile connection.
currently it subclasses existing relay, but will be updated later.
How did you test your changes?