Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Guard against concurrent withdraws causing unexpected reverts
- Loading branch information
1 parent
2662df1
commit 69dda7e
Showing
9 changed files
with
113 additions
and
51 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,27 +1,35 @@ | ||
PostOpTest:test_RevertsIfPostOpFailed(uint256,uint256,uint256) (runs: 256, μ: 94981, ~: 97095) | ||
GetHashTest:test_returnsValidHash() (gas: 46531) | ||
IsValidWithdrawalSignature:test_returnsFalseWithInvalidSignature() (gas: 53845) | ||
IsValidWithdrawalSignature:test_returnsTrueWithValidSignature() (gas: 51016) | ||
OwnerWithdrawTest:test_revertsIfNotOwner() (gas: 15305) | ||
OwnerWithdrawTest:test_transfersERC20Successfully(uint256) (runs: 256, μ: 97271, ~: 99711) | ||
OwnerWithdrawTest:test_transfersETHSuccessfully(uint256) (runs: 256, μ: 51418, ~: 53415) | ||
PostOpTest:test_RevertsIfPostOpFailed(uint256,uint256,uint256) (runs: 256, μ: 97167, ~: 99371) | ||
PostOpTest:test_entryPointAddStake(uint112,uint32) (runs: 256, μ: 56233, ~: 56233) | ||
PostOpTest:test_entryPointDeposit(uint112) (runs: 256, μ: 32331, ~: 32962) | ||
PostOpTest:test_entryPointUnlockStake() (gas: 54910) | ||
PostOpTest:test_entryPointWithdraw(uint112) (runs: 256, μ: 63500, ~: 65300) | ||
PostOpTest:test_entryPointWithdrawStake() (gas: 71825) | ||
PostOpTest:test_paymasterPaysForOp() (gas: 208402) | ||
PostOpTest:test_transfersExcess(uint256,uint256,uint256,uint256) (runs: 256, μ: 110216, ~: 111227) | ||
PostOpTest:test_entryPointDeposit(uint112) (runs: 256, μ: 32516, ~: 32962) | ||
PostOpTest:test_entryPointUnlockStake() (gas: 54888) | ||
PostOpTest:test_entryPointWithdraw(uint112) (runs: 256, μ: 63200, ~: 65300) | ||
PostOpTest:test_entryPointWithdrawStake() (gas: 71803) | ||
PostOpTest:test_paymasterPaysForOp() (gas: 210663) | ||
PostOpTest:test_transfersExcess(uint256,uint256,uint256,uint256) (runs: 256, μ: 112465, ~: 113488) | ||
Simulate:test() (gas: 12114) | ||
ValidatePaymasterUserOpTest:test_emitsCorrectly(address,uint256,uint256) (runs: 256, μ: 102564, ~: 103835) | ||
ValidatePaymasterUserOpTest:test_recordsNonceUsed(uint256) (runs: 256, μ: 109936, ~: 111025) | ||
ValidatePaymasterUserOpTest:test_returns1sIfWrongSignature() (gas: 94076) | ||
ValidatePaymasterUserOpTest:test_returnsCorrectly() (gas: 88920) | ||
ValidatePaymasterUserOpTest:test_emitsCorrectly(address,uint256,uint256) (runs: 256, μ: 104847, ~: 106080) | ||
ValidatePaymasterUserOpTest:test_recordsNonceUsed(uint256) (runs: 256, μ: 112158, ~: 113247) | ||
ValidatePaymasterUserOpTest:test_returns1sIfWrongSignature() (gas: 96298) | ||
ValidatePaymasterUserOpTest:test_returnsCorrectly() (gas: 91185) | ||
ValidatePaymasterUserOpTest:test_revertsIfMaxCostMoreThanRequested() (gas: 39141) | ||
ValidatePaymasterUserOpTest:test_revertsIfNonceUsed() (gas: 101280) | ||
ValidatePaymasterUserOpTest:test_revertsIfWithdrawAssetNotZero() (gas: 55974) | ||
ValidatePaymasterUserOpTest:test_revertsIfNonceUsed() (gas: 103502) | ||
ValidatePaymasterUserOpTest:test_revertsIfWithdrawAssetNotZero() (gas: 55952) | ||
ValidatePaymasterUserOpTest:test_reverts_whenWithdrawExceedsMaxAllowed(uint256,uint256,uint256) (runs: 256, μ: 100811, ~: 100992) | ||
ValidateTest:test_receive() (gas: 14687) | ||
WithdrawGasExcess:test_RevertsIfNoExcess(uint256) (runs: 256, μ: 68914, ~: 69177) | ||
WithdrawGasExcess:test_transferExcess(uint256,uint256,uint256) (runs: 256, μ: 102074, ~: 102074) | ||
WithdrawTest:test_emitsCorrectly(address,uint256,uint256) (runs: 256, μ: 115868, ~: 119073) | ||
WithdrawTest:test_emitsCorrectlyERC20Withdraw(address,uint256,uint256) (runs: 256, μ: 158052, ~: 160513) | ||
WithdrawTest:test_recordsNonceUsed(uint256) (runs: 256, μ: 109078, ~: 110167) | ||
WithdrawTest:test_revertsIfExpired(uint48,uint256) (runs: 256, μ: 59403, ~: 59535) | ||
WithdrawTest:test_revertsIfNonceUsed() (gas: 93506) | ||
WithdrawTest:test_revertsIfWrongSignature() (gas: 61536) | ||
WithdrawTest:test_transfersERC20Successfully(uint256) (runs: 256, μ: 136385, ~: 138825) | ||
WithdrawTest:test_transfersETHSuccessfully(uint256) (runs: 256, μ: 89398, ~: 91395) | ||
WithdrawGasExcess:test_RevertsIfNoExcess(uint256) (runs: 256, μ: 71133, ~: 71396) | ||
WithdrawGasExcess:test_transferExcess(uint256,uint256,uint256) (runs: 256, μ: 104279, ~: 104290) | ||
WithdrawTest:test_emitsCorrectly(address,uint256,uint256) (runs: 256, μ: 118413, ~: 121368) | ||
WithdrawTest:test_emitsCorrectlyERC20Withdraw(address,uint256,uint256) (runs: 256, μ: 162446, ~: 164773) | ||
WithdrawTest:test_recordsNonceUsed(uint256) (runs: 256, μ: 111372, ~: 112461) | ||
WithdrawTest:test_revertsIfExpired(uint48,uint256) (runs: 256, μ: 61664, ~: 61785) | ||
WithdrawTest:test_revertsIfNonceUsed() (gas: 95844) | ||
WithdrawTest:test_revertsIfWrongSignature() (gas: 63830) | ||
WithdrawTest:test_reverts_whenWithdrawExceedsMaxAllowed(uint256,uint256,uint256) (runs: 256, μ: 85124, ~: 85096) | ||
WithdrawTest:test_transfersERC20Successfully(uint256) (runs: 256, μ: 140626, ~: 143066) | ||
WithdrawTest:test_transfersETHSuccessfully(uint256) (runs: 256, μ: 91692, ~: 93689) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters