Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command flag for result file #317

Merged
merged 1 commit into from
May 20, 2022
Merged

Add command flag for result file #317

merged 1 commit into from
May 20, 2022

Conversation

irisZhangCB
Copy link
Contributor

@irisZhangCB irisZhangCB commented May 20, 2022 •
edited
Loading

Fixes # .

Motivation

  • Add command flag for result file when running check:data and check:construction
  • Upgrade cli version

Solution

Open questions

@irisZhangCB irisZhangCB marked this pull request as ready for review May 20, 2022 19:25
shiatcb
shiatcb approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@shiatcb shiatcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cb-heimdall
Copy link

Review Error for shiatcb @ 2022-05-20 19:36:47 UTC
User must have write permissions to review

@irisZhangCB irisZhangCB merged commit 4185c9d into coinbase:master May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaying-peng xiaying-peng xiaying-peng approved these changes

@shiatcb shiatcb shiatcb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@irisZhangCB @cb-heimdall @xiaying-peng @shiatcb