Add check spec for network list #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irisZhangCB
force-pushed
the
check-spec-iris
branch
2 times, most recently
from
eea51fe
to
33e85e1
Compare
shiatcb
reviewed
Jun 9, 2022
cmd/check_spec.go
Outdated
| return fmt.Errorf("network_identifiers are required") | ||
| } | ||
| for _, network := range networks.NetworkIdentifiers { | ||
| if types.Hash(network.Network) == types.Hash(Config.Network.Network) && |
There was a problem hiding this comment.
Can we just use network.Network == Config.Network.Network?
There was a problem hiding this comment.
And also in line 151: network.Blockchain == Config.Network.Blockchain?
There was a problem hiding this comment.
Oh I c, both network.Network and Config.Network.Network are pointers, that might be the reason to use types.Hash. Would you mind running the test locally and verify if types.Hash is needed?
There was a problem hiding this comment.
Confused myself. Both are strings, not pointers. In this case I don't think we need types.Hash.
irisZhangCB
force-pushed
the
check-spec-iris
branch
from
33e85e1
to
cde3f69
Compare
shiatcb
approved these changes
Jun 9, 2022
|
Review Error for shiatcb @ 2022-06-09 17:06:06 UTC |
shrimalmadhur
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Motivation
Add check spec for network list
Solution
Open questions