[Constructor] Inject Public Keys During Transaction Construction #133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: coinbase/mesh-cli#112
The
v1.4.3
release of the Rosetta Specification allows a Rosetta implementation to request the PublicKeys of any number of AccountIdentifiers for calls to/construction/metadata
and/construction/payloads
.This PR adds support for the
fetcher
to accept PublicKeys in calls to/construction/metadata
and/construction/payloads
and for theconstructor
to inject requested public keys automatically.Changes
ConstructionPreprocess
,ConstructionMetadata
, andConstructionPaylaods
types.PublicKey
during transaction construction in thecoordinator
Future PR
AccountIdentifier
inConstructionDeriveResponse
andSigningPayload
(non-breaking by adding field + deprecating)AccountIdentifier
instead of address (there may be multiple keys associated with the sameAccountIdentifier.Address
)