Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(wip) Madhur/revert go1.17 compat #398

Merged
merged 5 commits into from
Apr 21, 2022
Merged

(wip) Madhur/revert go1.17 compat #398

merged 5 commits into from
Apr 21, 2022

Conversation

shrimalmadhur
Copy link
Contributor

@shrimalmadhur shrimalmadhur commented Apr 18, 2022 •
edited
Loading

Fixes # .

Motivation

Due to the btcd issue which is leading to force update the repo to go1.17 and not support go1.16, reverting previous changes

Solution

Open questions

@coveralls
Copy link

coveralls commented Apr 18, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 16517

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.823%
Totals Coverage Status
Change from base Build 16495: 0.0%
Covered Lines: 8678
Relevant Lines: 11151
💛 - Coveralls

@shrimalmadhur shrimalmadhur merged commit d1ff359 into master Apr 21, 2022
@shrimalmadhur shrimalmadhur deleted the madhur/revert-go1.17-compat branch April 21, 2022 22:48
@cb-heimdall
Copy link

Review Error for GeekArthur @ 2022-04-21 22:48:59 UTC
User failed mfa authentication, see go/mfa-help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeekArthur GeekArthur GeekArthur approved these changes

@irisZhangCB irisZhangCB irisZhangCB approved these changes

@xiaying-peng xiaying-peng Awaiting requested review from xiaying-peng

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@shrimalmadhur @coveralls @cb-heimdall @GeekArthur @irisZhangCB