Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare Intent vs Observed Operations and Signers #78

Merged
merged 5 commits into from
Jul 23, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Jul 22, 2020

Related Issue: coinbase/mesh-cli#68

Changes

Compare intended vs observed operations and singers. This is useful when comparing the input to the Construction API with the output of /construction/parse.

@coveralls
Copy link

coveralls commented Jul 22, 2020

Pull Request Test Coverage Report for Build 2872

  • 83 of 87 (95.4%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 65.123%

Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/intent.go 83 87 95.4%
Totals Coverage Status
Change from base Build 2832: 0.9%
Covered Lines: 1955
Relevant Lines: 3002

💛 - Coveralls

@patrick-ogrady patrick-ogrady changed the title [WIP] Parse Intent Compare Intent vs Observed Operations and Signers Jul 23, 2020
@patrick-ogrady patrick-ogrady merged commit ecede8e into master Jul 23, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/intent-parser branch July 23, 2020 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants