Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert Successful Intent #83

Merged
merged 3 commits into from
Jul 25, 2020
Merged

Assert Successful Intent #83

merged 3 commits into from
Jul 25, 2020

Conversation

patrick-ogrady
Copy link
Contributor

Changes

  • Modify ExpectedOperations to allow for asserting success on matched operations
  • Print out all missing matches in ExpectedOperations error

@patrick-ogrady patrick-ogrady mentioned this pull request Jul 25, 2020
Closed
12 tasks
@patrick-ogrady patrick-ogrady requested a review from a team July 25, 2020 17:47
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2968

  • 26 of 27 (96.3%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 65.301%
Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/intent.go 26 27 96.3%
Files with Coverage Reduction New Missed Lines %
parser/intent.go 1 96.3%
Totals Coverage Status
Change from base Build 2934: 0.2%
Covered Lines: 1976
Relevant Lines: 3026
💛 - Coveralls

@patrick-ogrady patrick-ogrady merged commit 613a0e5 into master Jul 25, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/success-intent branch July 25, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yfl92 yfl92 yfl92 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@patrick-ogrady @coveralls @yfl92