Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: coinbase/mesh-cli#88
Regression introduced in: #89
The context returned by
errgroup.WithContext
is canceled as soon asg.Wait
returns. If this canceled context is passed to a handler or helper, it can have unintended consequences (some functions return immediately if the context is canceled).Source: https://godoc.org/golang.org/x/sync/errgroup
Changes
syncer
handler/helper is not canceled