Upgrade mongo driver to latest #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThatHurleyGuy
force-pushed
the
sean-hurley/upgrade-go-driver
branch
from
21ec17b
to
ceb7215
Compare
ThatHurleyGuy
force-pushed
the
sean-hurley/upgrade-go-driver
branch
2 times, most recently
from
b3c7687
to
0c887f0
Compare
ThatHurleyGuy
force-pushed
the
sean-hurley/upgrade-go-driver
branch
from
0c887f0
to
d271e6c
Compare
ThatHurleyGuy
commented
Oct 27, 2022
| - image: circleci/golang:1.14 | ||
| - image: circleci/mongo:4.2 | ||
| - image: cimg/go:1.18 | ||
| - image: circleci/mongo:5.0 |
There was a problem hiding this comment.
We were also behind on golang and mongo so I figured I'd bump them both "while I'm in there"
ThatHurleyGuy
commented
Oct 27, 2022
| steps: | ||
| - checkout | ||
|
|
||
| - restore_cache: | ||
| keys: | ||
| - v1-pkg-cache | ||
|
|
||
| - run: curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/fc0a898a6ae297c0ef59e2f1d824713d6f1cd222/install.sh | sh -s -- -d -b $(go env GOPATH)/bin v1.27.0 | ||
| - run: curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/a31485fe906612b2884239fdf7c55aec76ea7596/install.sh | sh -s -- -d -b $(go env GOPATH)/bin v1.50.1 |
There was a problem hiding this comment.
The old version no longer worked and was consistently failing on CI so this needed to be upgraded as well
ThatHurleyGuy
commented
Oct 28, 2022
| @@ -20,6 +20,10 @@ func (m *mockServer) MinRTT() time.Duration { | |||
| return time.Duration(0) | |||
| } | |||
|
|
|||
| func (m *mockServer) RTT90() time.Duration { | |||
| return time.Duration(0) | |||
| } | |||
There was a problem hiding this comment.
In the new version of the driver the Server interface added this RTT90 function that needed to be added to appease the type system
mbeasley
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for some incoming bugfixes to the golang driver (see https://jira.mongodb.org/browse/GODRIVER-2620) this PR upgrades the mongo driver to the latest version.