feat: framegear add styles for light mode, make legible #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You know I actually prefer light mode but I just went with what the designer gave me 😆 LGTM overall! The button link inside the top banner doesn't show up well, but we can add more comprehensive support in a future PR. |
cnasc
approved these changes
Feb 24, 2024
cc 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
I know, I know we should all be using darkmode all the time, but my machine is on auto, meaning light mode during the day. Right now lightmode in framegear makes most of the content illegible, and most importantly you can't read the URL that you're entering into the fetch frame input. I made simple changes that seem to be inline with the rest of the styling to support light mode, don't want to disrespect any plans you might have for implementing a design system etc, but this makes light mode usable for now.
This is what light mode looks like currently
This is what light mode looks like with changes
Notes to reviewers
How has it been tested?
Tested in Chrome Version 1.62.165 Chromium on MacOs 14.0 with light mode enabled, dark mode enabled and auto enabled.