Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for proto3 optional fields #24

Closed
wespen opened this issue Apr 29, 2021 · 1 comment · Fixed by #25
Closed

add support for proto3 optional fields #24

wespen opened this issue Apr 29, 2021 · 1 comment · Fixed by #25

Comments

@wespen
Copy link

wespen commented Apr 29, 2021

protoc v3.12.0 added support for the optional annotation to proto3 (see RC: https://github.com/protocolbuffers/protobuf/releases/tag/v3.12.0-rc1)

Trying optional fields generation now errors out with:
proto3 file that contains optional fields, but code generator protoc-gen-rbi hasn't been updated to support optional fields in proto3. Please ask the owner of this code generator to support proto3 optional.--rbi_out

@mdehoog
Copy link
Contributor

mdehoog commented May 3, 2021

Thanks for raising the issue. Waiting for lyft/protoc-gen-star/pull/85 to be merged to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants