Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waiting for implementation to reach tip before testing #155

Closed
fdmirza opened this issue Oct 7, 2020 · 2 comments
Closed

waiting for implementation to reach tip before testing #155

fdmirza opened this issue Oct 7, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@fdmirza
Copy link

fdmirza commented Oct 7, 2020

Describe the bug
Starting today, I am getting waiting for implementation to reach tip before testing... for check:construction

020/10/07 16:17:15 0 Balances Updated
2020/10/07 16:17:15 check:construction status server running on port 9090
2020/10/07 16:17:15 waiting for implementation to reach tip before testing...
[MEMORY] Heap: 1101.724197MB Stack: 0.656250MB System: 1260.756973MB GCs: 2
[STATS] Transactions Confirmed: 0 (Created: 0, In Progress: 0, Stale: 0, Failed: 0) Addresses Created: 0
2020/10/07 16:17:25 waiting for implementation to reach tip before testing...
[MEMORY] Heap: 1101.786850MB Stack: 0.656250MB System: 1260.756973MB GCs: 2

To Reproduce
Steps to reproduce the behavior:
run rosetta-cli check:construction --configuration-file <config.json>

Expected behavior
It should start check:construction flow

Additional context

 "online_url": <URL>,
  "data_directory": "",
  "http_timeout": 300,
  "max_retries": 5,
  "retry_elapsed_time": 0,
  "max_online_connections": 0,
  "max_sync_concurrency": 0,
  "tip_delay": 60,
  "log_configuration": false,
  "construction": {
    "offline_url": <URL>,
    "max_offline_connections": 0,
    "stale_depth": 0,
    "broadcast_limit": 0,
    "ignore_broadcast_failures": false,
    "clear_broadcasts": false,
    "broadcast_behind_tip": false,
    "block_broadcast_limit": 0,
    "rebroadcast_all": false,
    "constructor_dsl_file": "stacks.ros",
    "end_conditions": {
      "create_account": 10,
      "transfer": 10
    }
  }
@fdmirza fdmirza added the bug Something isn't working label Oct 7, 2020
@fdmirza fdmirza closed this as completed Oct 8, 2020
@patrick-ogrady
Copy link
Contributor

👋 @fdmirza! Thanks for posting this issue.

This is actually the new intended behavior of check:construction. Prior to the latest release, we would start syncing from the latest available block (which could be very far from tip if the implementation was still syncing). This led to storing unnecessary data on disk and often increased the time to start testing (because all blocks unrelated to construction testing would need to be synced). Once you connect to an implementation that is at tip (as defined by tip_delay), the test should start automatically!

I see you have stacks.ros in your config file! I hope you are enjoying the new DSL!

@patrick-ogrady
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants