Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

30% Reduction in Sync Time #88

Merged
merged 6 commits into from Aug 7, 2020
Merged

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Aug 6, 2020

Closes #87

Changes

Performance Testing

Blocks Synced: 1 million
Block Concurrency: 128

Before Optimization

Sync Time: 51 Minutes
Max Heap Allocation: 588 MB
Total Memory Obtained from OS: 1.13 GB
v0 4 0

After Optimization 馃帀 馃帀 馃帀

Sync Time: 35 Minutes (31% reduction)
Max Heap Allocation: 497 MB (15% reduction)
Total Memory Obtained from OS: 867 MB (23% reduction)
v0 4 1

@patrick-ogrady patrick-ogrady mentioned this pull request Aug 6, 2020
2 tasks
@coveralls
Copy link

coveralls commented Aug 6, 2020

Pull Request Test Coverage Report for Build 3181

  • 51 of 59 (86.44%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 71.687%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/storage/badger_storage.go 43 51 84.31%
Totals Coverage Status
Change from base Build 3078: 0.3%
Covered Lines: 1585
Relevant Lines: 2211

馃挍 - Coveralls

@patrick-ogrady patrick-ogrady changed the title Syncer + Memory Optimization [WIP] Syncer + Memory Optimization Aug 7, 2020
@patrick-ogrady patrick-ogrady changed the title [WIP] Syncer + Memory Optimization 30% Reduction in Sync Time Aug 7, 2020
@patrick-ogrady patrick-ogrady requested review from juliankoh and a team August 7, 2020 16:30
@patrick-ogrady patrick-ogrady merged commit cc2bac5 into master Aug 7, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/syncer-improvements branch August 7, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Out of Memory Error
3 participants