[utils] Implement PriorityMutex #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11943
💛 - Coveralls |
patrick-ogrady
requested review from
alex-stone,
bobg,
itstehkman,
septerr,
yfl92 and
cindyxkuang
alex-stone
reviewed
Nov 23, 2020
alex-stone
reviewed
Nov 23, 2020
bobg
reviewed
Nov 23, 2020
patrick-ogrady
commented
Nov 23, 2020
| func TestPriorityMutex(t *testing.T) { | ||
| arr := []bool{} | ||
| expected := make([]bool, 60) | ||
| l := new(PriorityMutex) |
There was a problem hiding this comment.
Good callout, @bobg !
bobg
approved these changes
Nov 23, 2020
itstehkman
reviewed
Nov 23, 2020
Comment on lines
+34
to
+35
| m sync.Mutex | ||
| l bool |
There was a problem hiding this comment.
small nit: use more descriptive variable names. l is not intuitive to somebody not implementing this
This was referenced Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: https://github.com/coinbase/rosetta-sdk-go/tree/patrick/priority-lock
In an effort to optimize
rosetta-cliperformance, we discovered that a priority lock could be used to prioritize the "hot path" (i.e. the syncing loop). This PR adds a basic implementation of such a lock calledPriorityMutex.Changes