Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[statefulsyncer] Add Variadic Initializer #250

Merged
merged 6 commits into from
Nov 24, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Nov 23, 2020

Related: https://github.com/coinbase/rosetta-sdk-go/tree/patrick/priority-lock

This PR adds a variadic function configuration option to statefulsyncer and adds support for configuring a custom pruning interval.

Changes

  • treat server idle connection issue as transient
  • make CounterStorage a BlockWorker so that we don't need to acquire 2 transactions while syncing
  • make AdjustmentWindow configurable in the syncer
  • increase default prune sleep time
  • reduce default syncer adjustment window (how often we try to increase sync concurrency)

@patrick-ogrady patrick-ogrady changed the title [statefulsyncer] Add Initialization Configuration [statefulsyncer] Add Variadic Initializer Nov 23, 2020
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12148

  • 13 of 54 (24.07%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 78.724%

Changes Missing Coverage Covered Lines Changed/Added Lines %
syncer/configuration.go 0 4 0.0%
storage/counter_storage.go 0 37 0.0%
Totals Coverage Status
Change from base Build 12100: -0.3%
Covered Lines: 7763
Relevant Lines: 9861

💛 - Coveralls

Copy link

@yfl92 yfl92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants