feat: support schnorr_1 for zilliqa #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@renlulu it won't let me merge this until you sign your commits 😢 |
|
@patrick-ogrady Oh ok! I will redo this PR. |
|
Looks good otherwise! |
renlulu
force-pushed
the
feat/schnorr_1
branch
from
3fff298
to
e14de5a
Compare
|
@patrick-ogrady I signed it. Hope you don't mind my force push here, or I can do a fresh PR. |
patrick-ogrady
approved these changes
Dec 1, 2020
|
force push is fine! |
This was referenced Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is to support Zilliqa schnorr signature algorithm.
Solution
Add
SignandVerifyfunctions forsecp256k1by using zilliqa golang sdk.