-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[reconciler] Performance Overhaul #258
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12826
💛 - Coveralls |
we are able to sync our node now with official SDK, I will retest again with these changes but so far so good, memory being held in check as well. (We have increased ours due to the database change size issue but can play around there once these changes are in) |
yfl92
approved these changes
Dec 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: https://github.com/coinbase/rosetta-sdk-go/tree/patrick/priority-lock
This PR introduces performance optimizations in the
reconciler
that reduce lock contention in the syncing loop. This PR also migratesBalanceStorage
,BlockStorage
, andCoinStorage
to usegithub.com/neilotoole/errgroup
(in practice, significantly reduces memory usage without impacting performance).Changes
reconciler
utils.ShardedMap
to track currently used accountscontext.Canceled
returned instead ofreconciliation fails
statefulsyncer
statefulsyncer
default pruning frequency to 10 minutesstorage
errgroup
limit withruntime.NumCPU
BlockStorage
is not using a global database transactionBlockStorage
to usegithub.com/neilotoole/errgroup
CoinStorage
to usegithub.com/neilotoole/errgroup