Add started_time to activity metadata

coinbase · May 9, 2023 · aaa69bf · aaa69bf
1 parent c9e7e38
commit aaa69bf
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 2 deletions.
diff --git a/lib/temporal/metadata.rb b/lib/temporal/metadata.rb
@@ -22,6 +22,7 @@ def generate_activity_metadata(task, namespace)
           workflow_name: task.workflow_type.name,
           headers: from_payload_map(task.header&.fields || {}),
           heartbeat_details: from_details_payloads(task.heartbeat_details),
+          started_at: task.started_time.to_time,
           scheduled_at: task.scheduled_time.to_time,
           current_attempt_scheduled_at: task.current_attempt_scheduled_time.to_time,
           start_to_close_timeout: task.start_to_close_timeout.seconds

diff --git a/lib/temporal/metadata/activity.rb b/lib/temporal/metadata/activity.rb
@@ -3,9 +3,13 @@
 module Temporal
   module Metadata
     class Activity < Base
-      attr_reader :namespace, :id, :name, :task_token, :attempt, :workflow_run_id, :workflow_id, :workflow_name, :headers, :heartbeat_details, :scheduled_at, :current_attempt_scheduled_at, :start_to_close_timeout
+      attr_reader :namespace, :id, :name, :task_token, :attempt, :workflow_run_id, :workflow_id, :workflow_name,
+                  :heartbeat_details, :started_at, :scheduled_at, :current_attempt_scheduled_at,
+                  :start_to_close_timeout, :headers
 
-      def initialize(namespace:, id:, name:, task_token:, attempt:, workflow_run_id:, workflow_id:, workflow_name:, headers: {}, heartbeat_details:, scheduled_at:, current_attempt_scheduled_at:, start_to_close_timeout:)
+      def initialize(namespace:, id:, name:, task_token:, attempt:, workflow_run_id:, workflow_id:, workflow_name:,
+                     heartbeat_details:, started_at:, scheduled_at:, current_attempt_scheduled_at:,
+                     start_to_close_timeout:, headers: {})
         @namespace = namespace
         @id = id
         @name = name
@@ -16,6 +20,7 @@ def initialize(namespace:, id:, name:, task_token:, attempt:, workflow_run_id:,
         @workflow_name = workflow_name
         @headers = headers
         @heartbeat_details = heartbeat_details
+        @started_at = started_at
         @scheduled_at = scheduled_at
         @current_attempt_scheduled_at = current_attempt_scheduled_at
         @start_to_close_timeout = start_to_close_timeout
@@ -36,6 +41,7 @@ def to_h
           'activity_id' => id,
           'activity_name' => name,
           'attempt' => attempt,
+          'started_at' => started_at.to_s,
           'scheduled_at' => scheduled_at.to_s,
           'current_attempt_scheduled_at' => current_attempt_scheduled_at.to_s,
         }

diff --git a/lib/temporal/testing/local_workflow_context.rb b/lib/temporal/testing/local_workflow_context.rb
@@ -61,6 +61,7 @@ def execute_activity(activity_class, *input, **args)
           workflow_name: self.metadata.name,
           headers: execution_options.headers,
           heartbeat_details: nil,
+          started_at: Time.now,
           scheduled_at: Time.now,
           current_attempt_scheduled_at: Time.now,
           start_to_close_timeout: 0
@@ -112,6 +113,7 @@ def execute_local_activity(activity_class, *input, **args)
           workflow_name: self.metadata.name,
           headers: execution_options.headers,
           heartbeat_details: nil,
+          started_at: Time.now,
           scheduled_at: Time.now,
           current_attempt_scheduled_at: Time.now,
           start_to_close_timeout: 0

diff --git a/spec/fabricators/activity_metadata_fabricator.rb b/spec/fabricators/activity_metadata_fabricator.rb
@@ -11,6 +11,7 @@
   workflow_name 'TestWorkflow'
   headers { {} }
   heartbeat_details nil
+  started_at { Time.now }
   scheduled_at { Time.now }
   current_attempt_scheduled_at { Time.now }
   start_to_close_timeout 0

diff --git a/spec/unit/lib/temporal/metadata/activity_spec.rb b/spec/unit/lib/temporal/metadata/activity_spec.rb
@@ -16,6 +16,7 @@
       expect(subject.workflow_name).to eq(args.workflow_name)
       expect(subject.headers).to eq(args.headers)
       expect(subject.heartbeat_details).to eq(args.heartbeat_details)
+      expect(subject.started_at).to eq(args.started_at)
       expect(subject.scheduled_at).to eq(args.scheduled_at)
       expect(subject.current_attempt_scheduled_at).to eq(args.current_attempt_scheduled_at)
     end
@@ -39,6 +40,7 @@
         'workflow_id' => subject.workflow_id,
         'workflow_name' => subject.workflow_name,
         'workflow_run_id' => subject.workflow_run_id,
+        'started_at' => subject.started_at.to_s,
         'scheduled_at' => subject.scheduled_at.to_s,
         'current_attempt_scheduled_at' => subject.current_attempt_scheduled_at.to_s,
       })