Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass url query for GET request instead of request.body #16

Merged
merged 4 commits into from Dec 3, 2017
Merged

Pass url query for GET request instead of request.body #16

merged 4 commits into from Dec 3, 2017

Conversation

toshipon
Copy link
Contributor

@toshipon toshipon commented Dec 3, 2017

I've done in this PR following things

  • Fixed not to send request body in read_positions. and send url params properly
  • Added simple public/private sample call file
  • Fixed host url to coincheck.com because coincheck.jp is no longer supported
  • Added custom user-agent

TODO:
will add rspec with API mock.

@toshipon toshipon changed the title (WIP) Pass url query for GET request instead of request.body (WIP) Pass a url query for GET request instead of request.body Dec 3, 2017
@toshipon toshipon changed the title (WIP) Pass a url query for GET request instead of request.body Pass url query for GET request instead of request.body Dec 3, 2017
@wadako111 wadako111 merged commit 09a0131 into master Dec 3, 2017
@wadako111 wadako111 deleted the fix-get-body branch December 3, 2017 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wadako111 wadako111 wadako111 approved these changes

@dogyearm dogyearm Awaiting requested review from dogyearm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@toshipon @wadako111