feat: [MDS-991] Bump minimum Flutter version to 3.16.8 (#347)

coingaming · Feb 14, 2024 · 4b946e4 · 4b946e4
1 parent ca354b8
commit 4b946e4
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/.github/workflows/analyze_and_test.yml b/.github/workflows/analyze_and_test.yml
@@ -12,7 +12,7 @@ jobs:
 
       - uses: subosito/flutter-action@v2
         with:
-          flutter-version: '3.13.5'
+          flutter-version: '3.16.8'
           channel: stable
 
       - name: Install Dependencies

diff --git a/.github/workflows/s3_deploy.yml b/.github/workflows/s3_deploy.yml
@@ -19,7 +19,7 @@ jobs:
 
       - uses: subosito/flutter-action@v2
         with:
-          flutter-version: '3.13.5'
+          flutter-version: '3.16.8'
           channel: stable
 
       - name: Install Dependencies

diff --git a/example/pubspec.yaml b/example/pubspec.yaml
@@ -3,7 +3,7 @@ description: Showcase Moon Design.
 publish_to: none
 version: 0.47.3
 environment:
-  sdk: '>=3.1.2 <4.0.0'
+  sdk: '>=3.2.5 <4.0.0'
 dependencies:
   cupertino_icons: ^1.0.2
   flutter:

diff --git a/lib/src/widgets/bottom_sheet/modal_bottom_sheet.dart b/lib/src/widgets/bottom_sheet/modal_bottom_sheet.dart
@@ -116,7 +116,7 @@ class MoonModalBottomSheetRoute<T> extends PageRoute<T> {
 
   AnimationController? _animationController;
 
-  bool get _hasScopedWillPopCallback => hasScopedWillPopCallback;
+  bool get _hasScopedWillPopCallback => popDisposition == RoutePopDisposition.pop;
 
   @override
   bool get maintainState => true;
@@ -238,7 +238,7 @@ class _ModalBottomSheetState<T> extends State<_ModalBottomSheet<T>> {
   }
 
   Future<bool> _handleShouldClose() async {
-    final RoutePopDisposition willPop = await widget.route.willPop();
+    final RoutePopDisposition willPop = widget.route.popDisposition;
 
     return willPop != RoutePopDisposition.doNotPop;
   }

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -5,7 +5,7 @@ homepage: https://flutter.moon.io/
 repository: https://github.com/coingaming/moon_flutter
 
 environment:
-  sdk: '>=3.1.2 <4.0.0'
+  sdk: '>=3.2.5 <4.0.0'
   flutter: ">=1.17.0"
 
 dependencies: