fix: [MDS-593] Upgrade Flutter to 3.10.5 (#205)

.github/workflows/analyze_and_test.yaml

@@ -12,7 +12,7 @@ jobs:
 
       - uses: subosito/flutter-action@v2
         with:
-          flutter-version: '3.7.12'
+          flutter-version: '3.10.5'
           channel: stable
 
       - name: Install Dependencies

.github/workflows/release.yml

@@ -10,6 +10,7 @@ jobs:
       - uses: google-github-actions/release-please-action@v3
         id: release
         with:
+          release-type: "dart"
           command: manifest
     outputs:
       release_created: ${{ steps.release.outputs.release_created }}

.github/workflows/s3_deploy.yml

@@ -17,7 +17,7 @@ jobs:
 
       - uses: subosito/flutter-action@v2
         with:
-          flutter-version: '3.7.12'
+          flutter-version: '3.10.5'
           channel: stable
 
       - name: Install Dependencies

example/android/build.gradle

@@ -26,6 +26,6 @@ subprojects {
     project.evaluationDependsOn(':app')
 }
 
-task clean(type: Delete) {
+tasks.register("clean", Delete) {
     delete rootProject.buildDir
 }

example/lib/main.dart

@@ -50,7 +50,6 @@ class _HomePageState extends State<HomePage> {
         : MaterialApp(
             theme: ThemeData.light().copyWith(extensions: <ThemeExtension<dynamic>>[MoonTheme.light]),
             darkTheme: ThemeData.dark().copyWith(extensions: <ThemeExtension<dynamic>>[MoonTheme.dark]),
-            useInheritedMediaQuery: true,
             home: Scaffold(
               body: Center(
                 child: Column(

example/lib/src/storybook/storybook.dart

@@ -25,12 +25,13 @@ import 'package:example/src/storybook/stories/text_area.dart';
 import 'package:example/src/storybook/stories/text_input.dart';
 import 'package:example/src/storybook/stories/toast.dart';
 import 'package:example/src/storybook/stories/tooltip.dart';
+import 'package:flutter/foundation.dart';
 import 'package:flutter/material.dart';
 import 'package:moon_design/moon_design.dart';
 import 'package:storybook_flutter/storybook_flutter.dart';
 
 class StorybookPage extends StatelessWidget {
-  static bool isLargeScreen = MediaQueryData.fromWindow(WidgetsBinding.instance.window).size.width > 1000;
+  static bool isLargeScreen = MediaQueryData.fromView(PlatformDispatcher.instance.implicitView!).size.width > 1000;
 
   const StorybookPage({super.key});
 
@@ -57,7 +58,6 @@ class StorybookPage extends StatelessWidget {
             title: "Moon Design for Flutter",
             theme: ThemeData.light().copyWith(extensions: <ThemeExtension<dynamic>>[MoonTheme.light]),
             darkTheme: ThemeData.dark().copyWith(extensions: <ThemeExtension<dynamic>>[MoonTheme.dark]),
-            useInheritedMediaQuery: true,
             home: Directionality(
               textDirection: Directionality.of(context),
               child: Focus(

example/pubspec.yaml

@@ -3,7 +3,7 @@ description: Showcase Moon Design.
 publish_to: none
 version: 0.25.0
 environment:
-  sdk: '>=2.18.6 <3.0.0'
+  sdk: '>=3.0.5 <4.0.0'
 dependencies:
   cupertino_icons: ^1.0.2
   flutter:
@@ -17,7 +17,7 @@ dev_dependencies:
   flutter_lints: ^2.0.0
   flutter_test:
     sdk: flutter
-  lint: ^2.0.1
+  lint: ^2.1.2
   storybook_flutter:
     git:
       url: https://github.com/coingaming/storybook_flutter.git

lib/src/utils/shape_decoration_premul.dart

@@ -98,7 +98,6 @@ class ShapeDecorationWithPremultipliedAlpha extends Decoration {
         } else {
           shape = const CircleBorder();
         }
-        break;
       case BoxShape.rectangle:
         if (source.borderRadius != null) {
           assert(source.border == null || source.border!.isUniform);
@@ -109,7 +108,6 @@ class ShapeDecorationWithPremultipliedAlpha extends Decoration {
         } else {
           shape = source.border ?? const Border();
         }
-        break;
     }
 
     return ShapeDecorationWithPremultipliedAlpha(

lib/src/utils/squircle/squircle_border.dart

@@ -191,8 +191,6 @@ class MoonSquircleBorder extends OutlinedBorder {
           outerPath,
           side.toPaint(),
         );
-
-        break;
     }
   }
 

lib/src/widgets/avatar/avatar.dart

@@ -177,7 +177,7 @@ class MoonAvatar extends StatelessWidget {
               child: ClipPath(
                 // TODO: Since clipper does not work properly on mobile web/PWA, we are disabling it. Remove this check
                 // when it has been fixed from Flutter side.
-                clipper: kIsWeb && MediaQueryData.fromWindow(WidgetsBinding.instance.window).size.width < 500
+                clipper: kIsWeb && MediaQueryData.fromView(View.of(context)).size.width < 500
                     ? null
                     : AvatarClipper(
                         showBadge: showBadge,

lib/src/widgets/carousel/carousel.dart

@@ -484,19 +484,19 @@ class MoonCarouselExtentMetrics extends FixedScrollMetrics {
   /// This is an immutable snapshot of the current values of scroll positions. This can directly be accessed by
   /// [ScrollNotification] to get currently selected real item index at any time.
   MoonCarouselExtentMetrics({
-    required super.axisDirection,
-    required super.maxScrollExtent,
     required super.minScrollExtent,
+    required super.maxScrollExtent,
     required super.pixels,
     required super.viewportDimension,
-    //TODO: uncomment when 3.10: required double devicePixelRatio,
+    required super.axisDirection,
+    required super.devicePixelRatio,
     required this.itemIndex,
   });
 
   @override
   MoonCarouselExtentMetrics copyWith({
     AxisDirection? axisDirection,
-    //TODO: uncomment when 3.10: double? devicePixelRatio,
+    double? devicePixelRatio,
     double? minScrollExtent,
     double? maxScrollExtent,
     double? pixels,
@@ -505,7 +505,7 @@ class MoonCarouselExtentMetrics extends FixedScrollMetrics {
   }) {
     return MoonCarouselExtentMetrics(
       axisDirection: axisDirection ?? this.axisDirection,
-      //TODO: uncomment when 3.10: devicePixelRatio: devicePixelRatio ?? this.devicePixelRatio,
+      devicePixelRatio: devicePixelRatio ?? this.devicePixelRatio,
       minScrollExtent: minScrollExtent ?? (hasContentDimensions ? this.minScrollExtent : 0.0),
       maxScrollExtent: maxScrollExtent ?? this.maxScrollExtent,
       pixels: pixels ?? this.pixels,
@@ -589,7 +589,7 @@ class _MoonCarouselScrollPosition extends ScrollPositionWithSingleContext implem
   @override
   MoonCarouselExtentMetrics copyWith({
     AxisDirection? axisDirection,
-    //TODO: uncomment when 3.10: double? devicePixelRatio,
+    double? devicePixelRatio,
     double? minScrollExtent,
     double? maxScrollExtent,
     double? pixels,
@@ -598,7 +598,7 @@ class _MoonCarouselScrollPosition extends ScrollPositionWithSingleContext implem
   }) {
     return MoonCarouselExtentMetrics(
       axisDirection: axisDirection ?? this.axisDirection,
-      //TODO: uncomment when 3.10: devicePixelRatio: devicePixelRatio ?? this.devicePixelRatio,
+      devicePixelRatio: devicePixelRatio ?? this.devicePixelRatio,
       minScrollExtent: minScrollExtent ?? (hasContentDimensions ? this.minScrollExtent : 0.0),
       maxScrollExtent: maxScrollExtent ?? this.maxScrollExtent,
       pixels: pixels ?? this.pixels,
@@ -708,7 +708,7 @@ class MoonCarouselScrollPhysics extends ScrollPhysics {
 
     // Scenario 3:
     // If there's no velocity and we're already at where we intend to land, do nothing.
-    //TODO: uncomment when 3.10: final tolerance = toleranceFor(metrics);
+    final tolerance = toleranceFor(metrics);
     if (velocity.abs() < tolerance.velocity && (settlingPixels - metrics.pixels).abs() < tolerance.distance) {
       return null;
     }

lib/src/widgets/common/icons/moon_icon.dart

@@ -234,7 +234,6 @@ class MoonIcon extends StatelessWidget {
             transformHitTests: false,
             child: iconWidget,
           );
-          break;
         case TextDirection.ltr:
           break;
       }

lib/src/widgets/common/progress_indicators/painters/linear_progress_indicator_painter.dart

@@ -75,10 +75,8 @@ class MoonLinearProgressIndicatorPainter extends CustomPainter {
       switch (textDirection) {
         case TextDirection.rtl:
           left = size.width - width - x;
-          break;
         case TextDirection.ltr:
           left = x;
-          break;
       }
 
       final progressRect = RRect.fromRectAndCorners(

lib/src/widgets/popover/popover.dart

@@ -392,32 +392,24 @@ class MoonPopoverState extends State<MoonPopover> with RouteAware, SingleTickerP
       switch (popoverPosition) {
         case MoonPopoverPosition.left:
           popoverPosition = MoonPopoverPosition.right;
-          break;
         case MoonPopoverPosition.right:
           popoverPosition = MoonPopoverPosition.left;
-          break;
         case MoonPopoverPosition.topLeft:
           popoverPosition = MoonPopoverPosition.topRight;
-          break;
         case MoonPopoverPosition.topRight:
           popoverPosition = MoonPopoverPosition.topLeft;
-          break;
         case MoonPopoverPosition.bottomLeft:
           popoverPosition = MoonPopoverPosition.bottomRight;
-          break;
         case MoonPopoverPosition.bottomRight:
           popoverPosition = MoonPopoverPosition.bottomLeft;
-          break;
         case MoonPopoverPosition.vertical:
           popoverPosition = popoverTargetGlobalCenter.dy < overlayRenderBox.size.center(Offset.zero).dy
               ? MoonPopoverPosition.bottom
               : MoonPopoverPosition.top;
-          break;
         case MoonPopoverPosition.horizontal:
           popoverPosition = popoverTargetGlobalCenter.dx < overlayRenderBox.size.center(Offset.zero).dx
               ? MoonPopoverPosition.right
               : MoonPopoverPosition.left;
-          break;
         default:
           break;
       }

lib/src/widgets/switch/switch.dart

@@ -222,11 +222,9 @@ class _MoonSwitchState extends State<MoonSwitch> with SingleTickerProviderStateM
         case TextDirection.rtl:
           _animationController!.value +=
               -details.primaryDelta! / (switchWidth - (thumbSizeValue + padding.right + padding.left));
-          break;
         case TextDirection.ltr:
           _animationController!.value +=
               details.primaryDelta! / (switchWidth - (thumbSizeValue + padding.right + padding.left));
-          break;
       }
     }
   }

lib/src/widgets/text_input/input_decorator.dart

@@ -1310,10 +1310,8 @@ class _RenderDecoration extends RenderBox with SlottedContainerRenderObjectMixin
       switch (textDirection) {
         case TextDirection.rtl:
           x = 0.0;
-          break;
         case TextDirection.ltr:
           x = _boxSize(icon).width;
-          break;
       }
       _boxParentData(container).offset = Offset(x, 0.0);
     }
@@ -1341,10 +1339,8 @@ class _RenderDecoration extends RenderBox with SlottedContainerRenderObjectMixin
       switch (textDirection) {
         case TextDirection.rtl:
           x = overallWidth - icon!.size.width;
-          break;
         case TextDirection.ltr:
           x = 0.0;
-          break;
       }
       centerLayout(icon!, x);
     }
@@ -1430,15 +1426,13 @@ class _RenderDecoration extends RenderBox with SlottedContainerRenderObjectMixin
           if (counter != null) {
             baselineLayout(counter!, left);
           }
-          break;
         case TextDirection.ltr:
           if (helperError != null) {
             baselineLayout(helperError!, left + _boxSize(icon).width);
           }
           if (counter != null) {
             baselineLayout(counter!, right - counter!.size.width);
           }
-          break;
       }
     }
 
@@ -1461,7 +1455,6 @@ class _RenderDecoration extends RenderBox with SlottedContainerRenderObjectMixin
             floatAlign,
           );
 
-          break;
         case TextDirection.ltr:
           // The value of _InputBorderGap.start is relative to the origin of the
           // _BorderContainer which is inset by the icon's width. Although, when
@@ -1475,7 +1468,6 @@ class _RenderDecoration extends RenderBox with SlottedContainerRenderObjectMixin
             _boxSize(container).width / 2.0 - floatWidth / 2.0,
             floatAlign,
           );
-          break;
       }
       decoration.borderGap.extent = label!.size.width * _kFinalLabelScale;
     } else {
@@ -1531,14 +1523,12 @@ class _RenderDecoration extends RenderBox with SlottedContainerRenderObjectMixin
           if (prefixIcon != null && !decoration.alignLabelWithHint && isOutlineBorder) {
             floatStartX += material3 ? _boxSize(prefixIcon).width - contentPadding.left : 0.0;
           }
-          break;
         case TextDirection.ltr: // origin on the left
           startX = labelOffset.dx;
           floatStartX = startX;
           if (prefixIcon != null && !decoration.alignLabelWithHint && isOutlineBorder) {
             floatStartX += material3 ? -_boxSize(prefixIcon).width + contentPadding.left : 0.0;
           }
-          break;
       }
       final double floatEndX = lerpDouble(floatStartX, centeredFloatX, floatAlign)!;
       final double dx = lerpDouble(startX, floatEndX, t)!;

lib/src/widgets/text_input/text_input.dart

@@ -924,7 +924,6 @@ class _MoonTextInputState extends State<MoonTextInput>
         if (cause == SelectionChangedCause.longPress || cause == SelectionChangedCause.drag) {
           _editableText?.bringIntoView(selection.extent);
         }
-        break;
     }
 
     switch (Theme.of(context).platform) {
@@ -938,7 +937,6 @@ class _MoonTextInputState extends State<MoonTextInput>
         if (cause == SelectionChangedCause.drag) {
           _editableText?.hideToolbar();
         }
-        break;
     }
   }
 
@@ -1235,7 +1233,6 @@ class _MoonTextInputState extends State<MoonTextInput>
         cursorRadius ??= const Radius.circular(2.0);
         cursorOffset = Offset(iOSHorizontalOffset / MediaQuery.of(context).devicePixelRatio, 0);
         autocorrectionTextRectColor = selectionColor;
-        break;
 
       case TargetPlatform.macOS:
         final CupertinoThemeData cupertinoTheme = CupertinoTheme.of(context);
@@ -1253,7 +1250,6 @@ class _MoonTextInputState extends State<MoonTextInput>
             _effectiveFocusNode.requestFocus();
           }
         };
-        break;
 
       case TargetPlatform.android:
       case TargetPlatform.fuchsia:
@@ -1263,7 +1259,6 @@ class _MoonTextInputState extends State<MoonTextInput>
         cursorOpacityAnimates = false;
         cursorColor = widget.cursorColor ?? effectiveTextColor;
         selectionColor = selectionStyle.selectionColor ?? theme.colorScheme.primary.withOpacity(0.40);
-        break;
 
       case TargetPlatform.linux:
         forcePressEnabled = false;
@@ -1272,7 +1267,6 @@ class _MoonTextInputState extends State<MoonTextInput>
         cursorOpacityAnimates = false;
         cursorColor = widget.cursorColor ?? effectiveTextColor;
         selectionColor = selectionStyle.selectionColor ?? theme.colorScheme.primary.withOpacity(0.40);
-        break;
 
       case TargetPlatform.windows:
         forcePressEnabled = false;
@@ -1287,7 +1281,6 @@ class _MoonTextInputState extends State<MoonTextInput>
             _effectiveFocusNode.requestFocus();
           }
         };
-        break;
     }
 
     final MouseCursor effectiveMouseCursor = MaterialStateProperty.resolveAs<MouseCursor>(
@@ -1541,7 +1534,7 @@ class _TextFieldSelectionGestureDetectorBuilder extends TextSelectionGestureDete
   }
 
   @override
-  void onSingleTapUp(TapUpDetails details) {
+  void onSingleTapUp(TapDragUpDetails details) {
     super.onSingleTapUp(details);
     _state._requestKeyboard();
     _state.widget.onTap?.call();
@@ -1560,7 +1553,6 @@ class _TextFieldSelectionGestureDetectorBuilder extends TextSelectionGestureDete
         case TargetPlatform.linux:
         case TargetPlatform.windows:
           Feedback.forLongPress(_state.context);
-          break;
       }
     }
   }