This repository has been archived by the owner on Jun 22, 2020. It is now read-only.
Add BitcoinIndonesia #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d0minicw0ng
reviewed
Jul 11, 2017
| ticker.last = output['last'] | ||
| ticker.high = output['high'] | ||
| ticker.low = output['low'] | ||
| ticker.volume = output["vol_#{ticker.base.downcase}"].to_f |
There was a problem hiding this comment.
@tmlee I mentioned this in the bitstamp PR, I wonder if we should use float or BigDecimal
There was a problem hiding this comment.
Actually maybe BigDecimal would be safer and sensible
There was a problem hiding this comment.
@tmlee yes let's use BigDecimal for all exclusively
There was a problem hiding this comment.
Noted lets create a separate pull request for that
d0minicw0ng
reviewed
Jul 12, 2017
| @@ -0,0 +1,19 @@ | |||
| :pairs: | |||
There was a problem hiding this comment.
@tmlee not that it matters, but do we need the extra colon in front? less keystrokes bro....
There was a problem hiding this comment.
I want to access the keys using :, any better ideas? Write custom methods? The helper methods are only available in Rails package i think
This was referenced Jul 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.