This repository has been archived by the owner on Jun 22, 2020. It is now read-only.
[#hotfix] Poloniex, Bittrex base/target swapped fix #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmlee
force-pushed
the
hotfix/base_target_swapped
branch
from
bc6ad55
to
9167382
Compare
d0minicw0ng
reviewed
Aug 20, 2017
| end | ||
|
|
||
| def ticker_url(market_pair) | ||
| base = market_pair.base | ||
| target = market_pair.target | ||
| "#{Cryptoexchange::Exchanges::Bittrex::Market::API_URL}/public/getmarketsummary?market=#{base}-#{target}" | ||
| # Bittrex pair has BTC comes first, when BTC is typically a Target not a Base | ||
| "#{Cryptoexchange::Exchanges::Bittrex::Market::API_URL}/public/getmarketsummary?market=#{target}-#{base}" |
There was a problem hiding this comment.
@tmlee Looking at the response of https://bittrex.com/api/v1.1/public/getmarketsummary?market=btc-ltc
{
"success": true,
"message": "",
"result": [
{
"MarketName": "BTC-LTC",
"High": 0.011225,
"Low": 0.01054107,
"Volume": 108671.50400962,
"Last": 0.01082199,
"BaseVolume": 1186.30109815,
"TimeStamp": "2017-08-20T05:07:00.463",
"Bid": 0.01082199,
"Ask": 0.010822,
"OpenBuyOrders": 1168,
"OpenSellOrders": 6783,
"PrevDay": 0.01100987,
"Created": "2014-02-13T00:00:00"
}
]
}
I think we should use Volume instead of BaseVolume?
d0minicw0ng
reviewed
Aug 20, 2017
| base: pair['BaseCurrency'], | ||
| target: pair['MarketCurrency'], | ||
| base: base, | ||
| target: target, |
There was a problem hiding this comment.
Looks like we should also use Volume not BaseVolume for Bleutrade
|
@tmlee looks good, we will have a separate PR to fix the Volume |
|
@dominicwong617 Thanks for looking into that as well |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.