Reloads onCurrentIndexChange function when state changes #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR @zshenkman. Would it be possible to amend this PR so that the changes do not include upgrades to dependencies? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Currently, the
onCurrentIndexChangefunction provided toLineChart.Providercan't always access up-to-date state contents. As a result, performing actions such as referencing the data point at the current index may not be possible if the data changes.How
This fix adds the
onCurrentIndexChangefunction as a dependency to theuseAnimatedReactionhook where it's called. This will allow the latest contents of the state to be accessed whenever the function is called.Additional Changes
This PR also updates the versions of packages in the example app.