add get_xpub_at_path function which can handle non-hardened derivations #24
Conversation
scgbckbone
commented
Jun 30, 2022
scgbckbone
commented
- copied from tapsigner branch in HWI as achow does not want to have this code in HWI
cktap/proto.py
Outdated
| """ | ||
| Sign 32 bytes digest and return 65 bytes long recoverable signature. | ||
|
|
||
| Uses derivation path based on current set derivation on card plus optional | ||
| subpath parameter which if provided, will be added to card derivation path. | ||
| Subpath can only be of length 2 and non-hardened components only. | ||
| if subpath is specified - use current derivation + derive subpath | ||
| if bip32_path is specified - subpath is ignored and derivation goes from root |
There was a problem hiding this comment.
bip32_path => fullpath or subkey_path ... maybe rename subpath too
There was a problem hiding this comment.
renamed:
subpath --> sub_deriv
bip32_path --> fullpath
There was a problem hiding this comment.
renamed sub_deriv back to subpath --> so we do not "fork" other people code
scgbckbone
force-pushed
the
xpub_at_path
branch
3 times, most recently
from
1be1121
to
87881e9
Compare
|
I think you've changed the (type of) arguments for a few functions here. This makes me "feel bad" since we are breaking working code that others may have written already. Can't we accept both str and |
|
only breaking change is renaming of sign_digest works as before - if you do not provide fullpath or am I missing something (besides subpath -> subderiv)? If subpath/sub_deriv is reverted I do not see any breaking changes there... |
|
oh - forgot about changed parameters to set_derivation/get_derivation -> I can also revert that (or we can bump minor version -> 1.1.0) |
|
changed few things:
|
scgbckbone
force-pushed
the
xpub_at_path
branch
2 times, most recently
from
c92a193
to
527899c
Compare
…tions; sign_digest adjusted to handle fullpath(bip32)
