Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: initial commit #7

Closed
wants to merge 9 commits into from
Closed

feat: initial commit #7

wants to merge 9 commits into from

Conversation

Mr00HasH
Copy link

Unnamed Exchange driver

@Mr00HasH
Create unnamedex.js
707e104 
Unnamed Exchange driver
@Mr00HasH Mr00HasH mentioned this pull request Dec 29, 2019
Closed
@nickpater
Copy link
Collaborator

nickpater commented Dec 29, 2019 •
edited

Thanks for your pull-request! 🎉 Can you switch the baseVolume and quoteVolume parameters? Because we've chosen to for example see BTC as quoteVolume in the BTCV_BTC market.

Oh and could you add it to the ./drivers/index.js file and add a fixture by running npm run test locally :)

@nickpater
Copy link
Collaborator

Hi @Mr00HasH, one of our team has listed Unnamed Exchange for you! I'm closing this one in favour of #13. Thanks again!

@nickpater nickpater closed this Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mr00HasH @nickpater