Config file written very frequently

[afh]

While working on some PRs and having the cointop configuration file open in my $EDITOR I noticed that cointop made changes to the config file. Inspecting filesystem operations on config.toml using fswatch it appears the configuration file is written to around 10 times per minutes (give or take a few) when cointop is running (see code snippet below), which seems unnecessary.

Any idea where that might originate from, @miguelmota?
I'd appreciate some pointers as to where the cause may lie and am happy to look into it and provide a PR.

% fswatch -tu ~/src/dotfiles/cointop/config.toml
Wed Apr 21 07:00:12 2021 /Users/afh/src/dotfiles/cointop/config.toml
Wed Apr 21 07:00:16 2021 /Users/afh/src/dotfiles/cointop/config.toml
Wed Apr 21 07:00:22 2021 /Users/afh/src/dotfiles/cointop/config.toml
Wed Apr 21 07:00:27 2021 /Users/afh/src/dotfiles/cointop/config.toml
Wed Apr 21 07:00:32 2021 /Users/afh/src/dotfiles/cointop/config.toml
Wed Apr 21 07:00:36 2021 /Users/afh/src/dotfiles/cointop/config.toml
Wed Apr 21 07:00:42 2021 /Users/afh/src/dotfiles/cointop/config.toml
Wed Apr 21 07:00:47 2021 /Users/afh/src/dotfiles/cointop/config.toml
Wed Apr 21 07:00:51 2021 /Users/afh/src/dotfiles/cointop/config.toml
Wed Apr 21 07:00:56 2021 /Users/afh/src/dotfiles/cointop/config.toml
Wed Apr 21 07:01:02 2021 /Users/afh/src/dotfiles/cointop/config.toml
Wed Apr 21 07:01:06 2021 /Users/afh/src/dotfiles/cointop/config.toml
Wed Apr 21 07:01:12 2021 /Users/afh/src/dotfiles/cointop/config.toml
Wed Apr 21 07:01:17 2021 /Users/afh/src/dotfiles/cointop/config.toml
Wed Apr 21 07:01:21 2021 /Users/afh/src/dotfiles/cointop/config.toml
Wed Apr 21 07:01:26 2021 /Users/afh/src/dotfiles/cointop/config.toml
Wed Apr 21 07:01:32 2021 /Users/afh/src/dotfiles/cointop/config.toml
Wed Apr 21 07:01:36 2021 /Users/afh/src/dotfiles/cointop/config.toml
Wed Apr 21 07:01:42 2021 /Users/afh/src/dotfiles/cointop/config.toml
Wed Apr 21 07:01:47 2021 /Users/afh/src/dotfiles/cointop/config.toml
Wed Apr 21 07:01:51 2021 /Users/afh/src/dotfiles/cointop/config.toml
Wed Apr 21 07:01:56 2021 /Users/afh/src/dotfiles/cointop/config.toml
Wed Apr 21 07:02:02 2021 /Users/afh/src/dotfiles/cointop/config.toml

[miguelmota]

@afh Looks like there were a few places that it was making unnecessary save write calls.

Writing to the config file here uses outil.WriteFile which triggers 4 fswatch events .

package main

import (
	"io/ioutil"
	"os"
)

func main() {
	path := "./file.txt"
	data := []byte("hello")
	if err := ioutil.WriteFile(path, data, os.FileMode(0644)); err != nil {
		panic(err)
	}
}

$ fswatch -tu file.txt
Sat 24 Apr 2021 09:49:26 PM GMT /home/mota/go/src/github.com/miguelmota/test/file.txt
Sat 24 Apr 2021 09:49:26 PM GMT /home/mota/go/src/github.com/miguelmota/test/file.txt
Sat 24 Apr 2021 09:49:27 PM GMT /home/mota/go/src/github.com/miguelmota/test/file.txt
Sat 24 Apr 2021 09:49:27 PM GMT /home/mota/go/src/github.com/miguelmota/test/file.txt

The method ct.Save() is invoked when performing actions like toggling favorites, editing portfolio, price alerts, preferred currency, etc. which causes file writes.

[afh]

Nice changes to reduce number of save calls, well done! 👏

I wonder if the the very frequent file writes I saw possibly had to do with two running instances of cointop…
I'm going to close this issue for now and will re-open with more reproducible instructions should the issue occur again.