Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blindly assigning properties to objects #1

Closed
eivindfjeldstad opened this issue Dec 19, 2013 · 4 comments
Closed

blindly assigning properties to objects #1

eivindfjeldstad opened this issue Dec 19, 2013 · 4 comments

Comments

@eivindfjeldstad
Copy link
Member

had a discussion about this in qs. it's not a big deal in this module since it doesn't support nesting, but it kinda sucks if someone decides to send a field named hasOwnProperty or overwrite some other prototype method.

ended up using a blacklist in qs, since setting __proto__ doesn't work with nullary objects anymore.

this is also a problem in co-busboy when autoFields = true.

I'll submit a PR if you're interested.

@jonathanong
Copy link
Contributor

Yeah. Let me add you as collab

@jonathanong
Copy link
Contributor

do you want npm rights? what's your npm username

@eivindfjeldstad
Copy link
Member Author

allright, cool! username is eivifj.

@jonathanong
Copy link
Contributor

yeah i don't personally use multipart since browsers have the file reader api and xhr2, so more maintainers would be helpful. i think all the multipart parsers need work too, and i don't keep track of them.

eivindfjeldstad added a commit that referenced this issue Dec 19, 2013
don't overwrite prototypes. closes #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants