Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Times sampling or divides in the Capon method of minvar function. #78

Open
xifenglu opened this issue Jun 16, 2022 · 0 comments
Open

Times sampling or divides in the Capon method of minvar function. #78

xifenglu opened this issue Jun 16, 2022 · 0 comments

Comments

@xifenglu
Copy link

1. Describe the bug
A clear and concise description of what the bug is.

2. To Reproduce
If you are facing a bug or installation problem, I cannot help yo without some information of way to reproduce the errors. Please complete the following information as much as possible

  • OS: [e.g. Fedora, windows version, mac version]
  • Python version. for example 3.7.2 (please provide X.Y.Z numbers)
  • Version of spectrum:

you can figure out the version using this python code::

import spectrum
spectrum.version

3.Expected behavior
A clear and concise description of what you expected to happen.

4.Screenshots
If applicable, add screenshots to help explain your problem.

5.What you think may explain the pbl

I like this module and it is so powerful. I have one question/confusion.

math:: P_{MV}(f) = \frac{T}{e^H(f) R^{-1}p e(f)}
def minvar(X, order, sampling=1., NFFT=default_NFFT):
.. math:: P
{MV}(f) = \frac{T}{e^H(f) R^{-1}_p e(f)}
......
# Invert the psi terms at this point to get PSD values
PSD = sampling / np.real(psi)

It times T in the math, but it times sampling in the PSD calculation inside the minvar function. I believe T=1/sampling. When sampling=1, there is no problem. If sampling !=1, it will get wrong answer for power or PSD. I may misunderstand, but can you please verify that.

Thanks.

Steve

@xifenglu xifenglu changed the title Times sampling or divides in the Capon method of Times sampling or divides in the Capon method of minvar function. Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant