New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
not saved any changes #48
Comments
Can you share your sample / what changes you made? I can't think of what could cause this with the description you provided. When I follow the exact same steps on dozens of inputs, it works fine. |
Going to close this seeing that the entire system has been rewritten, re-open this if it occurs in the redesign. |
This was most likely the same issue as #54 , which is properly resolved |
I downloaded and used Recaf 1.1.0 and getting this issue as well. I modified two class files in a jar package, but only the latter one got saved. I used the Save Jar button on the UI to save a new jar file. |
Well can you tell me exactly how you edited your file? I can't recreate this. |
I open a jar file, navigated to a package, updated an instruction from ICONST_0 to ICONST_1 in a class and closed the tab. Then I opened another file in another package, modified a few methods there, then I close tab again. I hit the Save Jar button to save everything into a jar file. In the end, I found the class I updated with the ICONST instruction remained unchanged. I was only able to create this once and couldn't confirm this can happen every time. |
Ok I'll see if I can get it to happen with that. Its likely that I just forgot to push a ClassDirtyEvent somewhere |
Github auto-closed based on commit name, but I'm pretty sure the commit resolved it. Check: https://github.com/Col-E/Recaf/releases/tag/1.1.1 for the update |
This my tester in last version
drag java file to recaf > select my class file > changes my code > save as new.jar
when i check my changes ..nothing happend and nothing changed
The text was updated successfully, but these errors were encountered: