Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Methods with the same name show results under one node #57

Closed
Col-E opened this issue Jun 2, 2018 · 2 comments
Closed

Methods with the same name show results under one node #57

Col-E opened this issue Jun 2, 2018 · 2 comments
Labels

Comments

@Col-E
Copy link
Owner

Col-E commented Jun 2, 2018

Take this example:

class A {
    void x() { String s = "example"; }
    void x(int i) { string s = "example"; }
}

If you were to search strings for example the results would show:

  • Class A
    • Method x
      • "example" <-- belongs to the first method
      • "example" <-- belongs to the second method (int i)

To Reproduce
Steps to reproduce the behavior:

  1. Search for something in an obfuscated assembly where method names match but method descriptors do not
  2. See results that match above

Solution

Associate results with name + description rather than just name. Showing the description is optional. Just the association matters.

@Col-E Col-E added the bug label Jun 2, 2018
@Col-E
Copy link
Owner Author

Col-E commented Jun 2, 2018

2ff9d10

@Col-E Col-E closed this as completed Jun 2, 2018
@Col-E
Copy link
Owner Author

Col-E commented Jun 2, 2018

Additionally to reduce confusion there is now an option (disabled by default) to show method types in results. Here is a comparison:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant