Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google analytics take 2 #131

Merged

Conversation

azrap
Copy link
Collaborator

@azrap azrap commented Oct 2, 2020

Analytics changes again!

  • added an analytics folder/file with a track function
  • used track function inside AddTripler.js on the component
  • used track function inside DataTable.js on the component
  • format changes only inside the router.js file

@litenull
Copy link
Contributor

litenull commented Oct 2, 2020

Hm, we're already doing this here
https://github.com/colab-coop/hello-voter/blob/ambassador-stage2/src/components/Button.js (line 55).
I think you can replace the button from "react-carbon-components" with the Button component we have.

@litenull
Copy link
Contributor

litenull commented Oct 2, 2020

Approving with a few caveats:

  • The styling of the button has "margin-top" which has to be tweaked (im not sure if its applied on some specific instance? and not applied for the search button. Then it looks good.
  • Pass through a type prop, which is "button" by default, otherwise it should be "submit"
  • Apply isAForm prop on the SeatchButtonStyled

For the nested button in the table:

  • Extrapolate code from line 55 in an export method
  • Use it directly there on the button

@azrap azrap marked this pull request as ready for review October 2, 2020 15:56
@litenull litenull merged commit cee8826 into colab-coop:ambassador-stage2 Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants