Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Behave acceptance tests #170

Merged
merged 2 commits into from
Apr 28, 2016
Merged

Behave acceptance tests #170

merged 2 commits into from
Apr 28, 2016

Conversation

gabrielssilva
Copy link
Contributor

Acceptance tests for:

  • Sign up
  • Sign in
  • Edit profile

Also, added steps necessary to run behave tests to the README

@gabrielssilva
Copy link
Contributor Author

The build is failing because behave_django is now listed in settings.py as a dependency. What should we do?

@lucasmoura
Copy link
Contributor

@gabrielssilva Maybe the problem is the fact that test/colab_settings.py is already adding behave_django to the INSTALLED_APPS variable ? I don't know for sure if that is the problem, but maybe it is worth checking it out :)

@lucaskanashiro
Copy link
Contributor

@lucasmoura +1 :)

@gabrielssilva
Copy link
Contributor Author

Yeah, that's the issue. We listed behave_django in INSTALLED_APPS to run it with colab-admin behave instead of python setup.py behave_tests. We will remove it from colab/seetings.py and stick with setup.py.

Although, as pointed in behave/behave#310, there is a bug when using setup.py to run the tests with behave <=1.2.5 (currently available in pypi). Installing the edge release fixes the problem, but the tests are failing for some reason.
Anyway, it is still possible to run with COLAB_SETTINGS=tests/colab_settings.py colab-admin behave. That's pretty much what happens in the Travis script.

We will check it out and update the documentation.

@gabrielssilva gabrielssilva force-pushed the behave_acceptance_tests branch 7 times, most recently from a9aed11 to 69c43ed Compare April 12, 2016 20:28
@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.282% when pulling 69c43ed on mes-2016-1:behave_acceptance_tests into 3ee7475 on colab:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.282% when pulling feb66e9 on mes-2016-1:behave_acceptance_tests into 3ee7475 on colab:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.282% when pulling 8addd94 on mes-2016-1:behave_acceptance_tests into 3ee7475 on colab:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.282% when pulling ffc3d71 on mes-2016-1:behave_acceptance_tests into 3ee7475 on colab:master.

gabrielssilva and others added 2 commits April 19, 2016 17:17
@gabrielssilva @Emiliemorais
Behave acceptance tests
ad6f618 
- Sign up
- Sign in
- Edit profile

Signed-off-by: Gabriel Silva <gabriel93.silva@gmail.com>
Signed-off-by: Italo Paiva <italosensei@hotmail.com>
Signed-off-by: Emiliemorais <emilie.mo@hotmail.com>
Signed-off-by: Matheus S. Pereira <matheussilva.fga@gmail.com>
Signed-off-by: Caique Pereira <caiquepereira@gmail.com>
Signed-off-by: Matheus S. Pereira <matheussilva.fga@gmail.com>
@italopaiva @Emiliemorais
Adding the process to run acceptance tests to the README
145a411 
Signed-off-by: Emiliemorais <emilie.mo@hotmail.com>
Signed-off-by: Italo Paiva <italosensei@hotmail.com>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.282% when pulling 145a411 on mes-2016-1:behave_acceptance_tests into 3ee7475 on colab:master.

@chaws
Copy link
Contributor

chaws commented Apr 28, 2016

Awesome work guys!

@chaws chaws merged commit 89f207e into colab:master Apr 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gabrielssilva @lucasmoura @lucaskanashiro @coveralls @chaws @italopaiva